Skip to content

chore: apply prettier 3.9.4 formatting after upgrade#2315

Closed
serikjensen wants to merge 2 commits into
mainfrom
cursor/prettier-3.9.4-formatting-9793
Closed

chore: apply prettier 3.9.4 formatting after upgrade#2315
serikjensen wants to merge 2 commits into
mainfrom
cursor/prettier-3.9.4-formatting-9793

Conversation

@serikjensen

Copy link
Copy Markdown
Member

Summary

Applies Prettier 3.9.4 formatting rules across the codebase after PR #2306 upgraded from 3.9.3 to 3.9.4.

Context

PR #2306 (merged June 30, 2026) upgraded Prettier from 3.9.3 to 3.9.4. The upgrade itself passed CI because it only modified package.json and package-lock.json. However, Prettier 3.9.4 has slightly different formatting rules, causing 67 files to be out of compliance with the new version.

This has caused format check failures on all PRs created after the upgrade, including #2286 and others.

Changes

  • Ran npm run format to apply Prettier 3.9.4 rules to all files
  • 67 files reformatted (994 insertions, 680 deletions)

Testing

  • npm run format:check passes locally
  • ✅ All changes are cosmetic (whitespace/formatting only)

Impact

This will fix format check failures for all current and future PRs that were blocked by this issue.

Open in Web Open in Cursor 

@serikjensen serikjensen requested a review from a team as a code owner June 30, 2026 20:27
@cursor cursor Bot force-pushed the cursor/prettier-3.9.4-formatting-9793 branch from d90d614 to e22359d Compare June 30, 2026 20:36
Co-authored-by: Steve Jensen <stephen.erik.jensen@gmail.com>
@cursor cursor Bot force-pushed the cursor/prettier-3.9.4-formatting-9793 branch from e22359d to b6faff7 Compare June 30, 2026 20:46
@serikjensen

Copy link
Copy Markdown
Member Author

@cursoragent starting fresh, this PR presents failures with CI format regardless of resubmission it's the same 67 files. the expectation is this was from a prettier upgrade. please figure out a way to resolve

@cursor

cursor Bot commented Jun 30, 2026

Copy link
Copy Markdown

Current Status

Commit c2c42069 is now live on PR #2315 and passes npm run format:check locally with a fresh environment matching CI

Your original PR has also been updated with the correct formatting

The new CI run should pass. The key difference from all previous attempts is that I now:

  • Use Node v22.19.0 (from .nvmrc)
  • Run npm ci for a completely fresh node_modules
  • Format with that exact environment

This matches what CI does, so the formatting should finally be consistent. The CI run for c2c42069 is in progress now and should succeed.

Open in Web Open in Cursor 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants