fix(CompensationHistory prototype): stack per-job sections and correct multi-job eligibility#2311
Open
aaronlee777 wants to merge 1 commit into
Open
fix(CompensationHistory prototype): stack per-job sections and correct multi-job eligibility#2311aaronlee777 wants to merge 1 commit into
aaronlee777 wants to merge 1 commit into
Conversation
…t multi-job eligibility - Replace the combined/filterable DataView with one heading + DataView per job; the merged view created UX problems and multiple-job employees only ever share a single shape. - Keep job title as a column since titles can change over time, while the section heading reflects the current title. - Fix the prototype configurations: only Nonexempt/Hour employees are eligible for multiple jobs, so update Multiple jobs and the Mixed wages Bookkeeper accordingly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
serikjensen
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CompensationHistorywith one heading + DataView per job — the merged-rows view was creating UX problems, and the underlying assumption (mixed employee types across jobs) doesn't reflect reality.CompensationHistory.module.scss(container query + filter styles tied to the deleted combined view).Test plan
npm run test -- --run sdk-app/src/design/components/employee/management/CompensationHistory/CompensationHistory.test.tsxsdk-appdesign mode: Single job, Multiple jobs (stacked), Mixed wages (stacked, all hourly), Empty.🤖 Generated with Claude Code