feat(contractor): add useContractorPaymentMethodForm hook#2302
Merged
Conversation
This was referenced Jun 29, 2026
Member
Author
|
@cursoragent fix the format issues that are failing CI |
|
Perfect! I've fixed the formatting issue that was causing the CI failure. What I did:
The formatting CI check should now pass on the next run.   |
| export type ContractorPaymentMethodFieldsMetadata = UseContractorPaymentMethodFormReady['form']['fieldsMetadata']; | ||
|
|
||
| // @public | ||
| export type ContractorPaymentMethodFormData = { type: "Check" | "Direct Deposit"; }; |
Contributor
There was a problem hiding this comment.
I love it when the derived types are easy to read
| export { | ||
| useContractorPaymentMethodForm, | ||
| ContractorPaymentMethodErrorCodes, | ||
| PAYMENT_METHOD_TYPES as ContractorPaymentMethodTypes, |
Contributor
There was a problem hiding this comment.
Why rename the export from a screaming case const to a pascal case? (actually a question)
Member
Author
There was a problem hiding this comment.
who am i to ask why claude does the things claude does?
Member
Author
There was a problem hiding this comment.
more seriously good catch! will fix
mariechatfield
approved these changes
Jun 30, 2026
mariechatfield
left a comment
mariechatfield
left a comment
Contributor
There was a problem hiding this comment.
Awesome this looks beautiful
Member
Author
|
@cursoragent fix the above export unneeded casing change and bring up to date/resolve conflicts |
|
Perfect! I've successfully completed both tasks: What I Fixed1. Export Casing Issue
2. Merged with Main
Commits Pushed
The branch is now up to date with main and the export follows proper naming conventions! |
Headless React Hook Form hook for a contractor's payment method type (Direct Deposit vs Check). On submit it PUTs the payment method; the Direct Deposit path defers bank-account creation to the bank account form, so this hook owns only the type selection and the Check write. Co-authored-by: Cursor <cursoragent@cursor.com>
The constant is an internal implementation detail. Partners have: - The hook which provides Fields.Type with options baked in - ContractorPaymentMethodFormType for TypeScript typing No need to expose the raw constant array.
cursor
Bot
force-pushed
the
feat/use-contractor-payment-method-form
branch
from
847bcf5 to
4a24ba4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useContractorPaymentMethodForm, a headless React Hook Form hook for a contractor's payment method type (Direct Deposit vs Check).PUTs the payment method. The Direct Deposit path defers actual bank-account creation touseContractorBankAccountForm, so this hook owns only the type selection and the Check write.TypeFieldsubcomponent and types via the public surface.Notes
useContractorBankAccountForm; PR3 integrates both into thePaymentMethodcomponent (and will supersede feat(contractor): migrate PaymentMethod to useContractorPaymentMethodForm hook #2293).Test plan
useContractorPaymentMethodFormunit + schema tests pass (6/6)npm run deriveregenerates API report + docsMade with Cursor