Switch client sync to use buffers instead of tags for data - #5336
Open
gustovafing wants to merge 31 commits into
Open
Switch client sync to use buffers instead of tags for data#5336gustovafing wants to merge 31 commits into
gustovafing wants to merge 31 commits into
Conversation
screret
suggested changes
Aug 23, 2026
screret
left a comment
Contributor
There was a problem hiding this comment.
The classes in the com.gregtechceu.gtceu.api.sync.transformers.gtceu package should be in com.gregtechceu.gtceu.common.sync.transformers, no?
Contributor
|
From the (failed) tests' logs: |
screret
suggested changes
Aug 23, 2026
TechLord22
reviewed
Aug 23, 2026
Co-authored-by: screret <68943070+screret@users.noreply.github.com>
Co-authored-by: screret <68943070+screret@users.noreply.github.com>
Co-authored-by: screret <68943070+screret@users.noreply.github.com>
Co-authored-by: screret <68943070+screret@users.noreply.github.com>
Co-authored-by: screret <68943070+screret@users.noreply.github.com>
Co-authored-by: screret <68943070+screret@users.noreply.github.com>
Co-authored-by: screret <68943070+screret@users.noreply.github.com>
Co-authored-by: screret <68943070+screret@users.noreply.github.com>
Co-authored-by: screret <68943070+screret@users.noreply.github.com>
Co-authored-by: screret <68943070+screret@users.noreply.github.com>
Co-authored-by: screret <68943070+screret@users.noreply.github.com>
Co-authored-by: screret <68943070+screret@users.noreply.github.com>
Co-authored-by: screret <68943070+screret@users.noreply.github.com>
Co-authored-by: screret <68943070+screret@users.noreply.github.com>
gustovafing
force-pushed
the
gus/update-sync
branch
from
August 24, 2026 00:44
14dca81 to
a0d399c
Compare
screret
reviewed
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Switches client sync data to be written into buffers instead of as tags, since NBT has a much higher packet size than buffers causing network issues.
AI Used: Jurre helping to debug an issue with Claude.
How Was This Tested
Tested a variety of BEs with client sync data in game, no issues