Cache pipe shapes by connection mask - #5327
Open
Marsietiss wants to merge 1 commit into
Open
Conversation
TarLaboratories
previously approved these changes
Aug 21, 2026
Contributor
|
Was this cache tested with pipes of different sizes but the same connections? i.e. if a tiny pipe connected N/S caches a collision box, will a huge pipe connected N/S pull the same collision box? or will it generate a new collision box for itself? |
TarLaboratories
dismissed
their stale review
August 21, 2026 09:51
sorry i thought PipeBlock had only 1 instance per pipe size
YoungOnionMC
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Caches the combined base
VoxelShapereturned byPipeBlock#getShapesfor each possible connection mask.Implementation Details
Adds a lazily populated 64 entry
AtomicReferenceArray<VoxelShape>to eachPipeBlock. The six connection bits are used as the cache index and compare-and-set safely publishes shapes when client and server threads query the same block at the same time.AI Usage
Outcome
Removes repeated construction of identical pipe shapes during collision queries.
Before: https://observable.tas.sh/p/kRjSS/aggregated


After: https://observable.tas.sh/p/SidOa/aggregated
How Was This Tested
./gradlew spotlessCheck buildagainst the current1.20.1branch.Potential Compatibility Issues
Should be none