Skip to content

Clean up nullability within material system - #5253

Open
gustovafing wants to merge 19 commits into
1.20.1from
gus/remove-null-material
Open

Clean up nullability within material system#5253
gustovafing wants to merge 19 commits into
1.20.1from
gus/remove-null-material

Conversation

@gustovafing

Copy link
Copy Markdown
Member

What

Cleans up the handling of null materials and values within the material system.

  • Removes the null material, replacing usages with null
  • Removes the null tag prefix, replacing usages with null
  • Requires all elements of a material entry to be non-null

@github-actions github-actions Bot added the 1.20.1 label Aug 6, 2026
@gustovafing gustovafing added type: refactor Suggestion to refactor a section of code Release: API - X.0.0 Major Breaking Refactors that MUST be in a API-Breaking Release labels Aug 6, 2026
@github-actions github-actions Bot added the Tests: Failed Game Tests have failed on this PR label Aug 6, 2026
Comment thread src/main/java/com/gregtechceu/gtceu/api/block/PipeBlock.java
Comment thread src/main/java/com/gregtechceu/gtceu/api/block/SimpleCoilType.java
# Conflicts:
#	src/main/java/com/gregtechceu/gtceu/api/block/MaterialBlock.java
@github-actions github-actions Bot added Tests: Passed Game Tests have passed on this PR and removed Tests: Failed Game Tests have failed on this PR labels Aug 6, 2026
@gustovafing
gustovafing marked this pull request as ready for review August 10, 2026 06:27
@gustovafing
gustovafing requested a review from a team as a code owner August 10, 2026 06:27
# Conflicts:
#	docs/content/Modpacks/Changes/v8.0.0.md
#	src/main/java/com/gregtechceu/gtceu/common/data/GTMaterials.java
@github-actions github-actions Bot added Tests: Failed Game Tests have failed on this PR and removed Tests: Passed Game Tests have passed on this PR labels Aug 15, 2026
@github-actions github-actions Bot added Tests: Passed Game Tests have passed on this PR and removed Tests: Failed Game Tests have failed on this PR labels Aug 15, 2026
}
}
return MaterialEntry.NULL_ENTRY;
return null;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@github-actions github-actions Bot added Tests: Failed Game Tests have failed on this PR Tests: Passed Game Tests have passed on this PR and removed Tests: Passed Game Tests have passed on this PR Tests: Failed Game Tests have failed on this PR labels Aug 16, 2026
# Conflicts:
#	src/main/java/com/gregtechceu/gtceu/api/multiblock/error/CoilMatchingError.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.20.1 Release: API - X.0.0 Major Breaking Refactors that MUST be in a API-Breaking Release Tests: Passed Game Tests have passed on this PR type: refactor Suggestion to refactor a section of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants