Remove GTRegistry in favour of mapped registries - #5160
Open
gustovafing wants to merge 78 commits into
Open
Conversation
gustovafing
added
type: refactor
screret
suggested changes
Jul 21, 2026
github-actions
Bot
added
Tests: Failed
gustovafing
force-pushed
the
gus/switch-forge-registries
branch
from
July 23, 2026 12:00
2942239 to
fb2b2eb
Compare
github-actions
Bot
added
Tests: Passed
gustovafing
force-pushed
the
gus/switch-forge-registries
branch
from
July 27, 2026 07:19
e658818 to
ff22a83
Compare
github-actions
Bot
added
Tests: Failed
jurrejelle
reviewed
Jul 30, 2026
Comment on lines
+352
to
+354
| if (!ConfigHolder.INSTANCE.compat.createCompat || !GTCEu.Mods.isCreateLoaded()) { | ||
| PlaceholderHandler.addPlaceholder(new Placeholder("redstone") { | ||
|
|
Contributor
There was a problem hiding this comment.
Not a full reivew, just quickly scrolling through: why are we gating the redstone placeholder behind create compat checks?
Member
Author
There was a problem hiding this comment.
we register a different redstone one if create is loaded
github-actions
Bot
added
Tests: Passed
screret
suggested changes
Aug 4, 2026
github-actions
Bot
added
Tests: Failed
screret
suggested changes
Aug 4, 2026
gustovafing
force-pushed
the
gus/switch-forge-registries
branch
from
August 5, 2026 03:53
15e1813 to
9dd50ff
Compare
# Conflicts: # src/main/java/com/gregtechceu/gtceu/integration/kjs/builders/machine/KJSTieredMachineBuilder.java
# Conflicts: # src/main/java/com/gregtechceu/gtceu/common/data/GTMaterials.java # src/main/resources/gtceu.mixins.json
jurrejelle
requested changes
Aug 15, 2026
jurrejelle
left a comment
jurrejelle
left a comment
Contributor
There was a problem hiding this comment.
Review assisted by Opus 5
Some sloppa'd up change notes that we probably do want in the change docs, since I don't see any docs for this change:
Old (GTRegistry) |
New (MappedRegistry) |
|---|---|
REG.register(id, value) |
GTRegistries.register(REG, id, value) |
REG.codec() |
REG.byNameCodec() |
REG.values() / .entries() |
.stream() / iterate the registry |
REG.getRegistryName() |
REG.key().location() |
REG.registerOrOverride(...) |
no replacement |
Renamed field: GTRegistries.PATTERN_ERRORS → PATTERN_ERROR_TYPES, and its registry id changes gtceu:pattern_errors → gtceu:pattern_error_type, idk if we care about that one tho
| public void modConstruct(FMLConstructModEvent event) { | ||
| // this is done to delay initialization of content to be after KJS has set up. | ||
| event.enqueueWork(CommonProxy::init); | ||
| public static void registerDataPackRegistries(DataPackRegistryEvent.NewRegistry event) { |
Contributor
There was a problem hiding this comment.
should this be deleted? if not, since this is static I think(?) it won't be picked up by forge
jurrejelle
reviewed
Aug 15, 2026
jurrejelle
left a comment
jurrejelle
left a comment
Contributor
There was a problem hiding this comment.
You need to run datagen on this PR
Contributor
There was a problem hiding this comment.
add the gtresourcelocation type binding
Member
Author
|
Hmm I didn't think there were any data changes |
# Conflicts: # src/main/java/com/gregtechceu/gtceu/api/recipe/GTRecipeSerializer.java # src/main/java/com/gregtechceu/gtceu/api/registry/registrate/MachineBuilder.java # src/main/java/com/gregtechceu/gtceu/common/CommonProxy.java # src/main/java/com/gregtechceu/gtceu/integration/kjs/GTCEuStartupEvents.java
# Conflicts: # src/main/java/com/gregtechceu/gtceu/integration/kjs/builders/recipe/GTRecipeTypeBuilder.java
github-actions
Bot
added
Tests: Failed
github-actions
Bot
added
Tests: Passed
# Conflicts: # src/main/java/com/gregtechceu/gtceu/api/machine/trait/MachineTraitHolder.java # src/main/java/com/gregtechceu/gtceu/api/sync_system/SyncDataHolder.java # src/main/java/com/gregtechceu/gtceu/api/sync_system/data_transformers/ValueTransformer.java # src/main/java/com/gregtechceu/gtceu/api/sync_system/data_transformers/collections/ListTransformer.java # src/main/java/com/gregtechceu/gtceu/api/sync_system/data_transformers/collections/MapTransformer.java # src/main/java/com/gregtechceu/gtceu/api/sync_system/data_transformers/collections/ObjectArrayTransformer.java # src/main/java/com/gregtechceu/gtceu/api/sync_system/data_transformers/collections/SetTransformer.java # src/main/java/com/gregtechceu/gtceu/api/sync_system/data_transformers/gtceu/CoverBehaviorTransformer.java # src/main/java/com/gregtechceu/gtceu/api/sync_system/managed/ManagedSavedData.java # src/main/java/com/gregtechceu/gtceu/api/sync_system/managed/ManagedSyncBlockEntity.java # src/main/java/com/gregtechceu/gtceu/common/item/behavior/PortableScannerBehavior.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes GTRegistry, replacing it with native MC registries.
Minor external API changes.
Uses a registration hack to allow registration before the register event, keeping our current registration system intact for time being, to be updated in the 9.0 registration refactor (same thing we do on 1.21)
No AI driven tools were used for this pull request.
How Was This Tested
Gametests pass, game starts and all content loads properly.