Port of the Forestry compatibility from 1.12.2 by Lepeo6565 · Pull Request #4940 · GregTechCEu/GregTech-Modern

Lepeo6565 · 2026-06-17T13:32:17Z

What

Port of the Forestry compatibility from 1.12.2

Implementation Details

All bees, combs, and frames from the 1.12.2 version have been ported.
The datagen related to these objects has been left disconnected for now, as I was unsure of the best way to integrate it into the current setup.
A service file was added because Forestry CE uses Java's ServiceLoader to discover and load addons.
Recipes for comb processing and frames still need to be implemented.
Forge was updated to a newer version to ensure compatibility with the latest Forestry CE update, as the previously used version was missing content required by the port.
[] No AI driven tools were used for this pull request.
Yes AI driven tools were used for this pull request.

Agent Used

ClaudeCode Opus 4.7
AI was used to write the tedious parts, such as the ResourceLocation entries for GTBeesSpecies

How Was This Tested

The mod was built and tested in a clean Minecraft instance, both with and without Forestry installed, and worked as intended

screret · 2026-06-17T13:59:58Z

add the generated files back in. As it is, this PR is flat out impossible to review.
you should add the new dependencies' maven locations to the appropriate exclusiveContent blocks (or add new ones) instead of duplicating them
- blamejared's maven, modrinth maven and thedarkcolour's actual maven are already in the list.
...there is no actual code in this PR?

screret · 2026-06-17T14:02:13Z

If there is code in this PR, it isn't showing up because the mass of 4000 removed files is hiding it.

Lepeo6565 · 2026-06-17T17:48:39Z

Just like you said, the code was hiding behind the JSONs. It's fixed now, and I’ve added a new exclusiveContent block

screret

All of the model files for comds should be generated at runtime like tag prefix items do.

screret · 2026-06-17T18:18:16Z

+patchouli = { module = "vazkii.patchouli:Patchouli", version.ref = "patchouli" }
+forestry  = { module = "maven.modrinth:forestry-community-edition", version.ref = "forestry" }
+modkit = { module = "com.github.thedarkcolour:ModKit", version.ref = "modkit" }


could you match the indents with the other entries above this?

screret · 2026-06-17T18:20:14Z

+        try {
+            for (Field field : GTBeesSpecies.class.getDeclaredFields()) {
+                if (field.getType() == ResourceLocation.class) {
+                    ResourceLocation location = (ResourceLocation) field.get(null);
+                    String speciesName = location.getPath();
+                    String speciesNameCap = speciesName.substring(0, 1).toUpperCase() + speciesName.substring(1);
+                    provider.add("allele.forestry.bee_species.gtceu." + speciesName, speciesNameCap);
+                }
+            }
+        } catch (IllegalAccessException e) {
+            e.printStackTrace();
+        }


WTF?? no this is absolutely not how this should be done.
also, if at all possible, don't duplicate the translations for the materials.

screret · 2026-06-17T18:20:42Z

maybe don't add the class at all if it's empty

screret · 2026-06-17T18:21:41Z

+@FeatureProvider
+public class GTApicultureItems {
+
+    public static final IFeatureRegistry REGISTRY = ModFeatureRegistry.get(new ResourceLocation(GTCEu.MOD_ID, "core"));


You should use GT's registrate instead of whatever this is. you'll get the same end result but without having to duplicate sot much stuff and/or make it jank.

screret · 2026-06-17T18:22:08Z

Do not make this an enum.

Seeing as how these are (almost) all based on materials, maybe make "comb" a material property?

screret · 2026-06-17T18:40:20Z

rename to GTBeeDefinitions

Make this use a material property instead of hardcoding all of it, please.

if you end up getting rid of the GTBeeSpecies class with all the IDs, this should be renamed GTBeeSpecies and not GTBeeDefinition because IBeeDefinition no longer exists in Forestry CE

screret · 2026-06-17T18:40:39Z

Just no. Don't do this.

you're probably referring to the reflection done in GTForestryLangProvider, and they shouldn't use this class for that purpose. however, a class with a list of species IDs is what Forestry does to avoid littering the code with string literals you have to hunt down if the IDs ever change.

if you do end up dropping this class, GTBeeDefinition should be GTBeeSpecies since there's no more IBeeDefinition in Forestry CE

IMO the ids shouldn't be stored as constants outside the bee species' constructors/registration

screret · 2026-06-17T18:41:01Z

+    public static final String GENUS_GT_ORGANIC    = "gt_organic";
+    public static final String GENUS_GT_INDUSTRIAL = "gt_industrial";
+    public static final String GENUS_GT_ALLOY      = "gt_alloy";
+    public static final String GENUS_GT_GEM        = "gt_gem";
+    public static final String GENUS_GT_METAL      = "gt_metal";
+    public static final String GENUS_GT_RAREMETAL  = "gt_raremetal";
+    public static final String GENUS_GT_RADIOACTIVE= "gt_radioactive";
+    public static final String GENUS_GT_NOBLEGAS   = "gt_noblegas";


why the gt_ prefix?

seconded, why not something more creative?

screret · 2026-06-17T18:41:42Z

+
+// CREDIT GOES TO: christopherwalkerml |
+// https://github.com/christopherwalkerml/MoBees/blob/main/src/main/java/com/noodlepfp/mobees/item/MoreBeesItemHiveFrame.java
+public class GTItemHiveFrame extends ItemForestry implements IHiveFrame {


Suggested change

public class GTItemHiveFrame extends ItemForestry implements IHiveFrame {

public class GTHiveFrameItem extends ItemForestry implements IHiveFrame {

screret · 2026-06-17T18:42:40Z

+                    .setMutationMult(1.2f)
+                    .setSpeedMult(1.8f)
+                    .setAgeMult(0.9f)
+                    .build(), "frame_accelerated");


Make the items' IDs match their language keys, e.g. this should be accelerated_frame, FRAME_MUTAGENIC's id should be mutagenic_frame, etc.

agreed. it's a bad pattern that Forestry has that i plan on abandoning in 1.21.1

thedarkcolour · 2026-06-19T00:55:04Z

you're probably referring to the reflection done in GTForestryLangProvider, and they shouldn't use this class for that purpose. however, a class with a list of species IDs is what Forestry does to avoid littering the code with string literals you have to hunt down if the IDs ever change.

thedarkcolour · 2026-06-19T01:49:35Z

if you do end up dropping this class, GTBeeDefinition should be GTBeeSpecies since there's no more IBeeDefinition in Forestry CE

thedarkcolour · 2026-06-19T01:50:03Z

+    public static final String GENUS_GT_ORGANIC    = "gt_organic";
+    public static final String GENUS_GT_INDUSTRIAL = "gt_industrial";
+    public static final String GENUS_GT_ALLOY      = "gt_alloy";
+    public static final String GENUS_GT_GEM        = "gt_gem";
+    public static final String GENUS_GT_METAL      = "gt_metal";
+    public static final String GENUS_GT_RAREMETAL  = "gt_raremetal";
+    public static final String GENUS_GT_RADIOACTIVE= "gt_radioactive";
+    public static final String GENUS_GT_NOBLEGAS   = "gt_noblegas";


seconded, why not something more creative?

thedarkcolour · 2026-06-19T01:52:00Z

+        modBus.addListener(ForestryClientHandler::registerItemColors);
+
+
+        ModuleUtil.getModBus(ForestryConstants.MOD_ID).addListener(EventPriority.HIGHEST, ((ForestryClientApiImpl) IForestryClientApi.INSTANCE)::initializeTextureManager);


there's no reason. AI tends to do this, i've also seen it in a vibecoded AI slop Forestry addon

thedarkcolour · 2026-06-19T01:53:49Z

+                    .setMutationMult(1.2f)
+                    .setSpeedMult(1.8f)
+                    .setAgeMult(0.9f)
+                    .build(), "frame_accelerated");


agreed. it's a bad pattern that Forestry has that i plan on abandoning in 1.21.1

thedarkcolour · 2026-06-19T01:58:43Z

+import java.text.DecimalFormat;
+import java.util.List;
+
+import javax.annotation.Nullable;


a holdover from old Forestry. they should have paid more attention to the GT code style.

thedarkcolour · 2026-06-19T02:00:01Z

+import java.util.function.Consumer;
+
+@ForestryModule
+public class GTForestryModule implements IForestryModule {


why are you reregistering Forestry's client code?? get rid of this.

thedarkcolour · 2026-06-19T02:00:26Z

+        GTBeeDefinition.register(apiculture);
+    }
+
+


this big gap probably needs reformatting too

thedarkcolour · 2026-06-19T02:01:32Z

 minecraft = "1.20.1"
-forge = "47.3.0"
-minecraftForge = "1.20.1-47.3.0"
+forge = "47.4.10"


is this safe to bump?

I didn’t encounter any issues with the version bump. That’s why I specified in my original PR that the version was bumped. I did this because Forestry forces you to use a newer version of Forge, but I would expect that this PR will need further checks

And for ForestryClientHandler I didn’t use AI because I didn’t find any documentation about Java add-ons. I used Mo' Bees as a base to see how it should be implemented. But yeah, I will probably get down to fix it between today and tomorrow. If there is any documentation that I missed, don’t hesitate to share it.

If you'd like some help with this, come ask in the Forestry CE Discord. I haven't written documentation for everything yet, but I do have an addon template: https://github.com/thedarkcolour/ForestryAddonTemplate/tree/main

thedarkcolour · 2026-06-19T02:02:22Z

if you end up getting rid of the GTBeeSpecies class with all the IDs, this should be renamed GTBeeSpecies and not GTBeeDefinition because IBeeDefinition no longer exists in Forestry CE

Co-authored-by: screret <68943070+screret@users.noreply.github.com>

Lepeo and others added 17 commits June 15, 2026 09:14

Include Patchouli and Forestry as dependencies

0e16514

fix

74cd7d6

fix

9b7569a

fix

5a50c20

update forge

e613671

update forestry

6055049

bees

a4f9a60

jsons

018c06f

jsons

51ffeea

adding combs in gt creative tab

c670007

fix depencies

633a670

gtceu frame

b2a81af

adding frames to creative tab

635a953

GTForestry datagen

7e115ce

frames assets

5635180

cleaning

e3c1566

Merge branch 'GregTechCEu:1.20.1' into 1.20.1

cdfae9f

Lepeo6565 requested a review from a team as a code owner June 17, 2026 13:32

github-actions Bot added the 1.20.1 label Jun 17, 2026

Lepeo added 3 commits June 17, 2026 19:19

adding the jsons

1361ea8

Merge remote-tracking branch 'origin/1.20.1' into 1.20.1

c450980

chore: move maven dependencies into exclusiveContent blocks

a99f222

chore: change modkit to modLocalRuntime

a7a82f9

screret suggested changes Jun 17, 2026

View reviewed changes

thedarkcolour suggested changes Jun 19, 2026

View reviewed changes

Lepeo6565 and others added 2 commits June 20, 2026 19:06

Update dependencies.gradle

14632e5

Co-authored-by: screret <68943070+screret@users.noreply.github.com>

chore: adding todos and small fixes

2885c11

thedarkcolour mentioned this pull request Jun 21, 2026

gregtech ceu compat? thedarkcolour/ForestryCE#320

Open

	public class GTItemHiveFrame extends ItemForestry implements IHiveFrame {
	public class GTHiveFrameItem extends ItemForestry implements IHiveFrame {

		modBus.addListener(ForestryClientHandler::registerItemColors);


		ModuleUtil.getModBus(ForestryConstants.MOD_ID).addListener(EventPriority.HIGHEST, ((ForestryClientApiImpl) IForestryClientApi.INSTANCE)::initializeTextureManager);

Uh oh!

Conversation

Lepeo6565 commented Jun 17, 2026

What

Implementation Details

Agent Used

How Was This Tested

Uh oh!

screret commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

screret commented Jun 17, 2026

Uh oh!

Lepeo6565 commented Jun 17, 2026

Uh oh!

screret left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thedarkcolour Jun 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

screret commented Jun 17, 2026 •

edited

Loading

thedarkcolour Jun 28, 2026 •

edited

Loading