Reflect excluded streams in the Streams page archiving indicator - #26974
Open
patrickmann wants to merge 4 commits into
Open
Reflect excluded streams in the Streams page archiving indicator#26974patrickmann wants to merge 4 commits into
patrickmann wants to merge 4 commits into
Conversation
The "Archiving is enabled" indicator on the Streams overview and stream details pages was computed only from the stream's index set retention strategy (archive retention strategy or data tiering archive-before-delete). It never consulted the archive plugin's excluded_streams list, so a stream excluded under Archive > Configuration > Streams to archive still showed as archiving enabled. Add a useExcludedArchiveStreams hook that reads the excluded list through the enterprise "archive" plugin-store export (with a no-op fallback for open source, where archiving is never enabled anyway) and treat a stream as archived only when its index set archives AND the stream is not excluded. Related: Graylog2/graylog-plugin-enterprise#14996 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Align with the customization plugin's plugin-store hook pattern: read the
enterprise export through usePluginEntities('archive') and the nested
`hooks` key, rather than raw PluginStore.exports.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
ArchivingsCell copied the `is_default || !is_editable` guard from the sibling action cells (outputs, pipelines, rules), which hid the archiving indicator for the default stream even though it writes to the default index set and is archived like any other stream. Archiving is a read-only status, not an editable action, so drop the guard and let the archiving state (index set archives AND stream not excluded) decide on its own. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
patrickmann
marked this pull request as ready for review
August 13, 2026 14:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/prd Graylog2/graylog-plugin-enterprise#15196
What
Make the "Archiving is enabled" indicator on the Streams overview and stream details pages reflect the archive plugin's excluded-streams list, not just the index set's retention strategy.
Why
The indicator was computed purely from the stream's index set (archive retention strategy, or data-tiering
archive_before_deletion). It never consulted the archive plugin'sexcluded_streamslist, so a stream excluded under Archive > Configuration > Streams to archive still showed as "Archiving is enabled". Reported in Graylog2/graylog-plugin-enterprise#14996.How
useExcludedArchiveStreams, which reads the excluded list through a newarchiveplugin-store export. In open source (no archive plugin) it returns an empty list via a stable no-op fallback, so the hook is always called and rules-of-hooks is satisfied. Archiving is never enabled without the enterprise plugin anyway.excluded_streams, in bothArchivingsCell(overview) andDestinationIndexSetSection(details). The details change also correctly gates the Data Lake warning, which keys off the same flag.PluginArchivetype to@types/graylog-web-plugin.Details
The enterprise side that provides the export is Graylog2/graylog-plugin-enterprise#15196. This PR degrades gracefully without it (indicator keeps its previous, index-set-only behavior), so there is no hard merge-order dependency.
How tested
yarn testforArchivingsCell.test.tsx(5 cases, incl. the excluded-stream regression) anduseExcludedArchiveStreams.test.ts(2 cases) — all green.Manual:
excluded_streams).Related
Types of changes
Checklist: