Show Outputs and Pipelines counts for the default stream - #26971
Open
patrickmann wants to merge 3 commits into
Open
Show Outputs and Pipelines counts for the default stream#26971patrickmann wants to merge 3 commits into
patrickmann wants to merge 3 commits into
Conversation
The Streams overview blanked the Outputs and Pipelines columns for the default stream via a copy-pasted is_default guard, even though outputs can be attached to it and pipelines commonly connect to it. Drop the is_default clause so the read-only counts render; add/remove actions stay guarded independently. Fixes Graylog2/graylog-plugin-enterprise#14572 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The expanded Outputs cell disabled its Manage Outputs button for the default stream via the same copy-pasted is_default guard, while the row action-menu Manage Outputs item and the Data Routing page both allow it. Drop the is_default clause so both controls behave consistently. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
patrickmann
marked this pull request as ready for review
August 13, 2026 11:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Show the Outputs and Pipelines count columns for the default stream in the Streams overview table, and make the expanded Manage Outputs button consistent with the rest of the UI for the default stream.
Why
Outputs and pipelines attached to the default stream were never displayed in the overview, even though other streams show them (Graylog2/graylog-plugin-enterprise#14572). The default stream can have outputs attached, and pipelines very commonly connect to it, so the empty columns were misleading.
How
OutputsCellandPipelinesCellbailed out with a copy-pasted guardstream.is_default || !stream.is_editable, inherited from the bulk column-addition in #19763. Theis_defaultclause was never appropriate for these two columns (unlike stream rules/status/archiving, which are genuinely N/A for the default stream). Dropped theis_defaultclause, keeping!stream.is_editable.ExpandedOutputsActions(the Manage Outputs button in the expanded Outputs cell) carried the same guard and was disabled for the default stream — inconsistent with the row action-menu's Manage Outputs item and the Data Routing page, which both already allow managing default-stream outputs. Dropped theis_defaultclause there too.Details
NonDeletableSystemScopeis mutable), so it renders; truly non-editable system streams remain hidden via the retained!is_editableclause.StreamOutputResourcehas no default-stream guard), so enabling the Manage Outputs button exposes no new capability — it just removes an inconsistency.RoutingPipelinesCellalready renders for the default stream, so this makes the three "attachable to default" columns consistent.How tested
Updated
PipelinesCell.test.tsxto assert the count renders for the default stream, andExpandedOutputsActions.test.tsxto assert Manage Outputs stays enabled for the default stream.Manual:
Related
Types of changes
Checklist: