Skip to content

Show Outputs and Pipelines counts for the default stream - #26971

Open
patrickmann wants to merge 3 commits into
masterfrom
fix/14572-default-stream-outputs-pipelines-cells
Open

Show Outputs and Pipelines counts for the default stream#26971
patrickmann wants to merge 3 commits into
masterfrom
fix/14572-default-stream-outputs-pipelines-cells

Conversation

@patrickmann

@patrickmann patrickmann commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

What

Show the Outputs and Pipelines count columns for the default stream in the Streams overview table, and make the expanded Manage Outputs button consistent with the rest of the UI for the default stream.

Why

Outputs and pipelines attached to the default stream were never displayed in the overview, even though other streams show them (Graylog2/graylog-plugin-enterprise#14572). The default stream can have outputs attached, and pipelines very commonly connect to it, so the empty columns were misleading.

How

OutputsCell and PipelinesCell bailed out with a copy-pasted guard stream.is_default || !stream.is_editable, inherited from the bulk column-addition in #19763. The is_default clause was never appropriate for these two columns (unlike stream rules/status/archiving, which are genuinely N/A for the default stream). Dropped the is_default clause, keeping !stream.is_editable.

ExpandedOutputsActions (the Manage Outputs button in the expanded Outputs cell) carried the same guard and was disabled for the default stream — inconsistent with the row action-menu's Manage Outputs item and the Data Routing page, which both already allow managing default-stream outputs. Dropped the is_default clause there too.

Details

  • The default stream is editable (NonDeletableSystemScope is mutable), so it renders; truly non-editable system streams remain hidden via the retained !is_editable clause.
  • Managing outputs on the default stream is fully supported (the backend's StreamOutputResource has no default-stream guard), so enabling the Manage Outputs button exposes no new capability — it just removes an inconsistency.
  • The backend already returns outputs and pipeline connections for the default stream with no special-casing, so no server change is needed.
  • RoutingPipelinesCell already renders for the default stream, so this makes the three "attachable to default" columns consistent.

How tested

Updated PipelinesCell.test.tsx to assert the count renders for the default stream, and ExpandedOutputsActions.test.tsx to assert Manage Outputs stays enabled for the default stream.

Manual:

  1. Add an output to the default stream (Stream → Data Routing → Destinations) and connect a pipeline to it.
  2. Open the Streams overview: the default stream row now shows non-zero Outputs and Pipelines count badges, and expanding them lists the entries.
  3. Expand the Outputs cell on the default stream row and confirm the Manage Outputs button is enabled and links to Data Routing → Destinations.

Related

  • Fixes Graylog2/graylog-plugin-enterprise#14572

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have requested a documentation update.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

patrickmann and others added 3 commits August 13, 2026 10:05
The Streams overview blanked the Outputs and Pipelines columns for the
default stream via a copy-pasted is_default guard, even though outputs
can be attached to it and pipelines commonly connect to it. Drop the
is_default clause so the read-only counts render; add/remove actions
stay guarded independently.

Fixes Graylog2/graylog-plugin-enterprise#14572

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The expanded Outputs cell disabled its Manage Outputs button for the
default stream via the same copy-pasted is_default guard, while the row
action-menu Manage Outputs item and the Data Routing page both allow it.
Drop the is_default clause so both controls behave consistently.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@patrickmann
patrickmann marked this pull request as ready for review August 13, 2026 11:14
@patrickmann
patrickmann requested a review from a team August 13, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant