Migrate ListGroup from react-bootstrap to custom implementation.#26409
Open
linuspahl wants to merge 9 commits into
Open
Migrate ListGroup from react-bootstrap to custom implementation.#26409linuspahl wants to merge 9 commits into
ListGroup from react-bootstrap to custom implementation.#26409linuspahl wants to merge 9 commits into
Conversation
linuspahl
changed the title
ListGroup from react-bootstrap to Mantine.ListGroup from react-bootstrap to custom implementation.
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We are migrating
react-bootstrapbased components to either a maninte based component or a custom implementation.This PR migrates the
ListGroupto a custom implementation. I tried migrating it to mantinesListcomponent, but it makes the implementation more complex and does not have many benefits.One structural change. Before the
ListGroupandListGroupItemwas not always anulandli. When using a link for theListGroupItemthey were actually anchors and no longer list items. The custom implementation handles this differently and always uses an HTML list.This simplifies the implementation and it has the benefit of following HTML best practices. Because of this change it was required to add a missing
ListGroupin some cases./prd https://github.com/Graylog2/graylog-plugin-enterprise/pull/14527
Related to #26330
/nocl