Repository navigation
Add the History panel - #4894
Open
TrueDoctor wants to merge 1 commit into
Open
TrueDoctor wants to merge 1 commit into
TrueDoctor wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 25 files
Confidence score: 3/5
- In
document/format/src/persist.rs, head movement can change registry fields thatToucheddoes not track, leaving the History panel’s storage cursor inconsistent. Mark this change as requiring a full rebuild.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="document/format/src/persist.rs">
<violation number="1" location="document/format/src/persist.rs:461">
P2: This records only the touched entities, but head movement can change registry fields that `Touched` does not track. Mark the change as requiring a full rebuild, otherwise the History panel can move the storage cursor while the editor still displays the old state.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| pub fn move_head(&mut self, rev: Rev) -> Result<(), Error> { | ||
| if self.retires_locally() { | ||
| let (moved, touched) = self.session.move_head_to(rev)?; | ||
| self.remote_changes.touched.extend(touched); |
Contributor
There was a problem hiding this comment.
P2: This records only the touched entities, but head movement can change registry fields that Touched does not track. Mark the change as requiring a full rebuild, otherwise the History panel can move the storage cursor while the editor still displays the old state.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At document/format/src/persist.rs, line 461:
<comment>This records only the touched entities, but head movement can change registry fields that `Touched` does not track. Mark the change as requiring a full rebuild, otherwise the History panel can move the storage cursor while the editor still displays the old state.</comment>
<file context>
@@ -452,6 +452,24 @@ impl<L: Layout> Gdd<L> {
+ pub fn move_head(&mut self, rev: Rev) -> Result<(), Error> {
+ if self.retires_locally() {
+ let (moved, touched) = self.session.move_head_to(rev)?;
+ self.remote_changes.touched.extend(touched);
+ self.persist_registry_snapshot()?;
+ self.persist_session_state()?;
</file context>
Suggested change
| self.remote_changes.touched.extend(touched); | |
| self.remote_changes.touched.extend(touched); | |
| self.remote_changes.rebuilt = true; |
TrueDoctor
force-pushed
the
graph-storage-24-history-panel
branch
from
November 1, 2026 11:36
f80208a to
36d14f9
Compare
TrueDoctor
force-pushed
the
graph-storage-24-history-panel
branch
from
November 1, 2026 14:34
36d14f9 to
4a7121b
Compare
TrueDoctor
force-pushed
the
graph-storage-24-history-panel
branch
from
November 1, 2026 16:41
4a7121b to
f25fbba
Compare
TrueDoctor
force-pushed
the
graph-storage-24-history-panel
branch
from
November 1, 2026 20:52
f25fbba to
866e62c
Compare
TrueDoctor
force-pushed
the
graph-storage-24-history-panel
branch
from
November 1, 2026 21:03
866e62c to
b64bd98
Compare
TrueDoctor
force-pushed
the
graph-storage-24-history-panel
branch
from
November 1, 2026 22:08
b64bd98 to
23ec54e
Compare
TrueDoctor
force-pushed
the
graph-storage-24-history-panel
branch
from
November 2, 2026 08:11
23ec54e to
746caaa
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.