Skip to content

Fix build-stack manifest tag on PRs #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mvalancy merged 1 commit into from
Jun 13, 2026
Merged

Fix build-stack manifest tag on PRs #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/docker-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,12 +102,19 @@ jobs:
- name: Determine tag
id: tag
run: |
if [[ "${{ github.ref }}" == "refs/heads/main" ]]; then
# Must match a tag the build-and-push job actually pushed (see the
# docker/metadata-action tags above), or imagetools can't find the
# per-image manifests. On PRs metadata pushes `pr-<number>`; on main
# it pushes `latest`. The old `${GITHUB_SHA::8}` fallback was never a
# pushed tag, so build-stack failed on every PR.
if [[ "${{ github.event_name }}" == "pull_request" ]]; then
echo "tag=pr-${{ github.event.number }}" >> $GITHUB_OUTPUT
elif [[ "${{ github.ref }}" == "refs/heads/main" ]]; then
echo "tag=latest" >> $GITHUB_OUTPUT
elif [[ "${{ github.ref }}" == refs/heads/* ]]; then
echo "tag=${GITHUB_REF#refs/heads/}" | sed 's/\//-/g' >> $GITHUB_OUTPUT
else
echo "tag=${GITHUB_SHA::8}" >> $GITHUB_OUTPUT
echo "tag=sha-${GITHUB_SHA::7}" >> $GITHUB_OUTPUT
fi

- name: Create and push manifest for stack
Expand Down
Loading