Add the ability to rename annotations added by the Scala compiler.#756
Add the ability to rename annotations added by the Scala compiler.#756shawjef3 wants to merge 3 commits into
Conversation
|
@johnrengelman The build failed due to a temporary godaddy failure. Please retrigger the build. |
|
Can you merge master to this. There’s a fix there. |
|
@johnrengelman it passed. Thanks! |
|
@johnrengelman I'm wondering if you've run into this. I want to use this patch with a project I have locally. I publish it.
In my project I use I looked at the class in the jar in my local repo, and it does have the annotation. However, when I debug Gradle's |
|
I also asked for help in the Gradle Slack. |
|
I was able to use |
|
I figured out what's happening. Something about my patch makes annotation classes be shaded also. This could be desirable but in this case it's not. I'll figure out how to make it only shade that Scala annotations. |
| ClassWriter cw = new ClassWriter(0) | ||
|
|
||
| ClassVisitor cv = new ClassRemapper(cw, remapper) | ||
| ClassVisitor cv = new ScalaSigClassVisitor(new ClassRemapper(cw, remapper), remapper.scalaRenamer) |
There was a problem hiding this comment.
We should compat Kotlin as well, need further work like #1539.
This is for #146. I haven't tested the new functionality, but existing tests pass.