Mark CONSTANT_TIME_FOR_ZIP_ENTRIES as const#2074
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts ShadowCopyAction.CONSTANT_TIME_FOR_ZIP_ENTRIES to be exposed as a true static field on the JVM (via @JvmField), while keeping ABI compatibility by reintroducing the previous getter as a deprecated function.
Changes:
- Add
@JvmFieldto exposeCONSTANT_TIME_FOR_ZIP_ENTRIESas a static field. - Add a deprecated
getCONSTANT_TIME_FOR_ZIP_ENTRIES()method for ABI compatibility. - Update the Kotlin ABI dump (
api/shadow.api) to reflect the new static field.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowCopyAction.kt | Exposes the timestamp constant as a JVM static field and preserves the old getter as deprecated for ABI compatibility. |
| api/shadow.api | Records the new static field in the public API dump. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Goooler
force-pushed
the
g/20260629/deprecate-const
branch
from
9895d9c to
4f3b8ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.