Refine deprecations#2072
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines deprecation annotations/messages across Shadow’s Kotlin APIs to better guide consumers toward replacements and to clarify the planned removal target (Shadow 10).
Changes:
- Improved deprecation messages (and in some cases added
ReplaceWith) to point to recommended APIs and Shadow 10 removal. - Deprecated
InheritManifest.inheritFrom(..)overloads more explicitly and added suppressions where needed for overrides.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/PreserveFirstFoundResourceTransformer.kt | Refines deprecation metadata for the resources property. |
| src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowCopyAction.kt | Clarifies constructor deprecation messaging and Shadow 10 timeline. |
| src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/InheritManifest.kt | Updates deprecation messages and adds deprecation to the inheritFrom(.., action) overload. |
| src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/DefaultInheritManifest.kt | Adds suppression for overriding newly-deprecated API. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.