Support scroll-to-top on proxy list#243
Open
Goooler wants to merge 1 commit into
Open
Conversation
Goooler
force-pushed
the
add-scroll-to-top-button
branch
2 times, most recently
from
4292f5c to
3993a62
Compare
Goooler
force-pushed
the
add-scroll-to-top-button
branch
from
3993a62 to
8c9dfb7
Compare
There was a problem hiding this comment.
Pull request overview
Adds a scroll-to-top floating action button for the proxy list, with supporting scaffold and theme updates so the button can be displayed consistently in the shared UI.
Changes:
- Adds FAB support to
TabbyScaffold. - Adds proxy-list grid state tracking and a scroll-to-top FAB in
ProxyScreen. - Adds an arrow-up vector icon and maps primary container colors for FAB styling.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
ui/src/main/kotlin/com/github/kr328/clash/ui/theme/Theme.kt |
Sets primary container colors used by Material3 components such as FABs. |
ui/src/main/kotlin/com/github/kr328/clash/ui/icon/BaselineArrowUp.kt |
Adds the arrow-up icon used by the new FAB. |
ui/src/main/kotlin/com/github/kr328/clash/ui/component/TabbyScaffold.kt |
Exposes a floatingActionButton slot through the shared scaffold wrapper. |
ui/proxy/src/main/kotlin/com/github/kr328/clash/proxy/ui/ProxyScreen.kt |
Tracks pager/grid state and adds the scroll-to-top FAB for proxy pages. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| scope.launch { currentGridState.animateScrollToItem(0) } | ||
| } | ||
| ) { | ||
| Icon(imageVector = TabbyIcons.BaselineArrowUp, contentDescription = null) |
Comment on lines
+233
to
+235
| floatingActionButton = { | ||
| if (showScrollToTopFab) { | ||
| FloatingActionButton( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.