Skip to content

fix(livestream): stop all channels before pool update to avoid FAILED_PRECONDITION#4312

Open
angelcaamal wants to merge 2 commits intomainfrom
fix/livestream-pool-update
Open

fix(livestream): stop all channels before pool update to avoid FAILED_PRECONDITION#4312
angelcaamal wants to merge 2 commits intomainfrom
fix/livestream-pool-update

Conversation

@angelcaamal
Copy link
Copy Markdown
Contributor

@angelcaamal angelcaamal commented May 8, 2026

Description

Fixes Internal: b/511248282

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@angelcaamal angelcaamal added samples Issues that are directly related to samples. api: livestream Issues related to the Live Stream API API. labels May 8, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the test cleanup logic in livestream.test.js to attempt stopping all channels before checking their age. The review feedback suggests filtering channels by a name prefix to prevent disrupting other test runs and refining the error handling to check for specific error codes when a channel fails to stop.

Comment thread media/livestream/test/livestream.test.js Outdated
Comment thread media/livestream/test/livestream.test.js Outdated
@angelcaamal angelcaamal marked this pull request as ready for review May 8, 2026 19:54
@angelcaamal angelcaamal requested review from a team as code owners May 8, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: livestream Issues related to the Live Stream API API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant