Skip to content

Revert "Migrate data_source_google_compute_images.go data source to use direct HTTP rather than a client library" - #18643

Merged
rileykarson merged 1 commit into
mainfrom
revert-18466-data_source_google_compute_images-migration
Aug 14, 2026
Merged

Revert "Migrate data_source_google_compute_images.go data source to use direct HTTP rather than a client library"#18643
rileykarson merged 1 commit into
mainfrom
revert-18466-data_source_google_compute_images-migration

Conversation

@melinath

@melinath melinath commented Aug 13, 2026

Copy link
Copy Markdown
Member

Reverts #18466 due to incorrect int conversion.

compute: migrated `google_compute_images` data source to use direct HTTP rather than a client library (revert)
compute: fixed truncation of results at 500 images in `google_compute_images` data source (revert)

@modular-magician

modular-magician commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b625b74:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 18 insertions(+), 73 deletions(-)
google-beta provider View Diff 1 file changed, 18 insertions(+), 73 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1556 1459 95 2
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@melinath VCR tests complete for b625b74!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants