Update dataproc batch tests to use new public bucket. - #18638
Open
animeshnandanwar wants to merge 2 commits into
Open
Update dataproc batch tests to use new public bucket.#18638animeshnandanwar wants to merge 2 commits into
animeshnandanwar wants to merge 2 commits into
Conversation
The existing bucket has revoked public access due to org policy updates. Updated bucket to match public access requirement. Fixes hashicorp/terraform-provider-google#25952 Fixes hashicorp/terraform-provider-google#25955
modular-magician
added
the
awaiting-approval
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
SirGitsalot
reviewed
Aug 13, 2026
SirGitsalot
left a comment
SirGitsalot
left a comment
Member
There was a problem hiding this comment.
LGTM, but I'm concerned about the provenance of the script. If it's not actually executed then this PR is good to go.
|
|
||
| pyspark_batch { | ||
| main_python_file_uri = "https://storage.googleapis.com/terraform-batches/test_util.py" | ||
| main_python_file_uri = "https://storage.googleapis.com/terraform-serverless/test_util.py" |
Member
There was a problem hiding this comment.
When the test run and the google_dataproc_batch resource is created, does this script get executed? And if so, what does it do and what access control is applied to it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update dataproc batch tests to use new public bucket.
Fixes hashicorp/terraform-provider-google#25952
Fixes hashicorp/terraform-provider-google#25955