Align Plugin Framework provider block cardinality with SDKv2 - #18607
Open
pose wants to merge 1 commit into
Open
Conversation
The SDKv2 provider schema declares external_credentials and batching with MaxItems: 1. The duplicated Plugin Framework schema constrains neither, so the two halves of the muxed provider disagree on cardinality. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
modular-magician
added
the
awaiting-approval
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDKv2 provider schema declares
external_credentialsandbatchingwithMaxItems: 1. The duplicated Plugin Framework schema declares both as plainListNestedBlockwith no size validator, so the two halves of the muxed provider disagree on cardinality.Adds
listvalidator.SizeAtMost(1)to both blocks.Note for reviewers:
listvalidator.SizeAtMost(1)is deliberate rather than incidental. Downstream consumers (for example the Pulumi Terraform bridge) recover a Plugin Framework block'sMaxItemsby matching the validator's description string,list must contain at most 1 elements. An equivalent hand-rolled validator would satisfy Terraform but leave the constraint undetectable downstream.Related: hashicorp/terraform-provider-google#19643 tracks the same class of SDKv2-vs-Plugin-Framework provider schema divergence for string validation.
Release Note Template for Downstream PRs (will be copied)