Add google_compute_service_attachments plural data source

[vr-ibm]

Fixes hashicorp/terraform-provider-google#23397

Adds a new plural data source google_compute_service_attachments that lists all service attachments in a given project and region, enabling discovery without hardcoding names or self_links.

Details

• Calls the serviceAttachments.list compute API with pagination support
• Accepts optional project, region, and filter arguments
• Returns a service_attachments list with key attributes: name, self_link, target_service, connection_preference, nat_subnets, enable_proxy_protocol, domain_names, fingerprint, region
• Adds acceptance test TestAccDataSourceGoogleComputeServiceAttachments_basic
• Adds documentation

Tests

TestAccDataSourceGoogleComputeServiceAttachments_basic

Release Note Template for Downstream PRs (will be copied)

`google_compute_service_attachments`

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit cc812dd:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	3 files changed, 417 insertions(+)
google-beta provider	View Diff	3 files changed, 417 insertions(+)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1548	1450	95	3

Affected Service Packages

• compute

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccComputeInstanceFromMachineImage_diffProject
• TestAccComputeReservation_reservationSharingPolicyExample
• TestAccDataSourceGoogleComputeServiceAttachments_basic

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccDataSourceGoogleComputeServiceAttachments_basic
❌ Error · Log	-	TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log	-	TestAccComputeReservation_reservationSharingPolicyExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@vr-ibm VCR tests complete for cc812dd!

[BBBmau]

@modular-magician reassign-reviewer

[github-actions]

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[github-actions]

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 21585c7:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	3 files changed, 373 insertions(+)
google-beta provider	View Diff	3 files changed, 373 insertions(+)

Step 1: Replaying Mode

Caution

Panic occurred during VCR tests

🔴 REPLAYING mode: The provider crashed with a panic. Please check the build log for details.

Please fix the issue to complete your PR.

View the build log

@vr-ibm, @BBBmau VCR tests complete for 21585c7!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d80366b:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	3 files changed, 373 insertions(+)
google-beta provider	View Diff	3 files changed, 373 insertions(+)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1557	1459	95	3

Affected Service Packages

• compute

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccComputeInstanceFromMachineImage_diffProject
• TestAccComputeRouterPeer_UpdateMd5AuthenticationKey
• TestAccComputeSecurityPolicy_withPreconfiguredWafConfig

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccComputeRouterPeer_UpdateMd5AuthenticationKey
❌ Error · Log	-	TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log	-	TestAccComputeSecurityPolicy_withPreconfiguredWafConfig

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@vr-ibm, @BBBmau VCR tests complete for d80366b!

[github-actions]

@vr-ibm, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

[BBBmau]

is there a reason for using the client library here? i check the normal resource of this data source and it uses transport, we lean more towards using transport since client libraries are more difficult in supporting new fields that get added to the API

[rileykarson]

No compute client libraries please, yep! #18639