Skip to content

refactor(vision): Migration of face_detection_dependencies region tag - Step 2/2#10306

Merged
Kef131 merged 1 commit into
mainfrom
refactor(vision)-remove_facedetection_regiontag_migrated
Jul 16, 2026
Merged

refactor(vision): Migration of face_detection_dependencies region tag - Step 2/2#10306
Kef131 merged 1 commit into
mainfrom
refactor(vision)-remove_facedetection_regiontag_migrated

Conversation

@Kef131

@Kef131 Kef131 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes #
b/347826377

Migration process for face_detection_dependencies region tag to vision_face_detection_dependencies regiont tag.

Checklist

Testing

  • I have tested this change on a live environment and verified it works as intended.
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only

Compliance & Style

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample

Post-Approval Actions

  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label Bot added api: vision Issues related to the Cloud Vision API. samples Issues that are directly related to samples. labels Jul 16, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes redundant XML comment tags ([START face_detection_dependencies] and [END face_detection_dependencies]) from the pom.xml file. I have no further feedback to provide.

@XrossFox XrossFox left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amcolin
amcolin marked this pull request as ready for review July 16, 2026 22:23
@amcolin
amcolin requested review from a team and yoshi-approver as code owners July 16, 2026 22:23

@amcolin amcolin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snippet-bot

snippet-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@Kef131
Kef131 merged commit aca9cb1 into main Jul 16, 2026
15 checks passed
@Kef131
Kef131 deleted the refactor(vision)-remove_facedetection_regiontag_migrated branch July 16, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: vision Issues related to the Cloud Vision API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants