add cli argument for model config#232
Conversation
m-y-mo
requested review from
JarLob,
Kwstubbs,
anticomputer,
kevinbackhouse,
p- and
sylwia-budzynska
as code owners
There was a problem hiding this comment.
Pull request overview
Adds support for specifying a model configuration reference via a CLI option when running taskflows, allowing the CLI-provided value to override the taskflow’s embedded model_config_ref.
Changes:
- Add
--model-config/-moption to the Typer CLI. - Thread the CLI model config through
run_main(...). - Override
taskflow_doc.model_config_refwith the CLI-provided value during taskflow execution.
Show a summary per file
| File | Description |
|---|---|
src/seclab_taskflow_agent/cli.py |
Adds --model-config option and forwards it into run_main. |
src/seclab_taskflow_agent/runner.py |
Accepts cli_model_config and uses it to override the taskflow’s model config reference. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 4
There was a problem hiding this comment.
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0 new
anticomputer
left a comment
anticomputer
left a comment
There was a problem hiding this comment.
Please address PR feedback.
|
Addressed first two copilot comments. Not entirely sure what meaningful unit test we can put in with the current infrastructure. ( |
|
@anticomputer: are your requested changes resolved? |
anticomputer
left a comment
anticomputer
left a comment
There was a problem hiding this comment.
Addressed: added TestCliModelConfigOverride test suite (6 tests) in test_runner.py covering override precedence, resolution via _resolve_model_config, session persistence, and resume behavior. Also added 2 session-level tests in test_session.py for cli_model_config persistence and defaults.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Fix docstring arg order: match resume_session_id, cli_model_config parameter order in run_main signature - Persist cli_model_config in TaskflowSession for deterministic resume: restored automatically on resume, can be explicitly overridden with --model-config - Add TestCliModelConfigOverride test suite (6 tests) covering override precedence, resolution, session persistence, and resume behavior - Add session-level tests for cli_model_config persistence and defaults Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
anticomputer
force-pushed
the
cli_model_config
branch
from
1c1e706 to
3cce7ba
Compare
- Add -m to architecture diagram CLI flags listing - Document model config persistence in session recovery section - Add CLI override subsection under Model configs with usage example Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
anticomputer
force-pushed
the
cli_model_config
branch
from
3cce7ba to
ab1f815
Compare
they are now 👍 |
Allow model config file to be passed via cli argument when running taskflows