chore: pass OpenAPI generator config via --opt flags#1743
Draft
gpunto wants to merge 1 commit into
Draft
Conversation
The chat-side Kotlin generator now takes its configuration through the generic `--opt key=value` flag (via the Configurable interface) instead of bespoke named flags. Update the generation script accordingly: - Convert the generate-client invocation to `--opt key=value` form. - Drop `--model-dir` (the generator hardcodes the models directory; the flag was a no-op) and its now-unused MODEL_DIR variable / argument. - classes-to-skip is space-separated (the --opt slice flag splits comma lists). - Point REFERENCE_VALUE at `master`, since the generator changes land there. Generated output is unchanged (byte-identical vs the previous generator).
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
|
Contributor
SDK Size Comparison 📏
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of AND-1306
Goal
The backend Kotlin OpenAPI generator was refactored so it takes its configuration through the generic
--opt key=valueflag (theConfigurableinterface master already uses for Swift) instead of a set of bespoke named flags. This keeps the sharedchatgenerator command free of language-specific flags. This PR updates the video client generation script to match the new interface.Implementation
generate-clientinvocation to--opt key=valueform.--model-dir: the generator hardcodes the models directory, so the flag was a no-op. Removed the flag, itsMODEL_DIRvariable, and its argument handling.classes-to-skipis now space-separated — the--optslice flag splits comma-separated values, so a comma list would be mangled.REFERENCE_VALUEatmaster(the end state is the generator branch merged intomaster).🎨 UI Changes
N/A — build/tooling script only.
Testing
Ran the generator against the updated backend and compared the produced
stream-video-android-core/.../generated/output to the previous generator: byte-identical (354 files, no differences). No SDK code changes result from this script update.☑️Contributor Checklist
General
developbranchCode & documentation