Conversation
Contributor
SDK Size
|
szuperaz
commented
Apr 10, 2026
| "{{count}} Files_many": "{{count}} Files", | ||
| "{{count}} Files_one": "{{count}} File", | ||
| "{{count}} Files_other": "{{count}} Files", | ||
| "{{count}} Photos_many": "{{count}} Photos", |
Author
There was a problem hiding this comment.
TODO: ask Ivan, because these don't seem to work but Voice message ({{duration}}) does
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
RTL mode fixes from QA test
🛠 Implementation details
1. Mirror icons based on Figma
All icons from this table should be mirrored after this PR is merged:
IconArrowBoxLeftleavepackage/src/icons/leave.tsx(ArrowBoxLeft)IconArrowLeftarrow-leftexamples/SampleApp/src/icons/GoBack.tsx(GoBack) — back chevron; in core, closest directional stroke icon ispackage/src/icons/chevron-left.tsx(ChevronLeft)GoBackonly)IconArrowRightarrow-rightexamples/SampleApp/src/icons/RightArrow.tsx(RightArrow) — arrow path flipped with a fixedmatrix(-1 …); optional chevron-style:examples/SampleApp/src/icons/GoForward.tsx(GoForward)RightArrow; yes forGoForwardIconArrowUpRightarrow-leftpackage/src/icons/arrow-up-right.tsx(ArrowUpRight)IconBubblesmessage-bubblesmessage-bubblesfile. Closest in SampleApp:examples/SampleApp/src/icons/ChatsTab.tsx(overlapping chat bubbles). In core, only single-outline bubble:package/src/icons/message-bubble.tsx(MessageBubbleEmpty)IconBubbleText6ChatMessagethreadpackage/src/icons/thread.tsx(ThreadReply)IconBubbleText6Solidthread-fillthread-fillicon in these folders)IconBubble2message-bubblepackage/src/icons/message-bubble.tsx(MessageBubbleEmpty)IconBubble2Solidmessage-bubble-fillmessage-bubblevariant in these folders)IconChevronLeftchevron-leftpackage/src/icons/chevron-left.tsx(ChevronLeft) — not re-exported frompackage/src/icons/index.tsbut used via direct importIconChevronRightchevron-rightchevron-rightin core icons.examples/SampleApp/src/icons/GoForward.tsx(GoForward) matches chevron-right behaviorIconArrowShareLeftreplypackage/src/icons/reply.tsx(CurveLineLeftUp/ aliasArrowShareLeft)IconLayoutLeftsidebarIconMagnifyingGlassSearchsearchpackage/src/icons/search.tsx(Search); SampleApp duplicate:examples/SampleApp/src/icons/Search.tsxIconMinusSmallmutepackage/src/icons/mute.tsx(Mute); SampleApp:examples/SampleApp/src/icons/Mute.tsxIconPaperPlanesendpackage/src/icons/send.tsx(SendRight)IconVideovideopackage/src/icons/video.tsx(VideoIcon)IconVideoSolidvideo-fillpackage/src/icons/video-fill.tsx(Recorder— filled camera / video glyph; filename isvideo-fill)IconVolumeFullaudiopackage/src/icons/audio.tsx(Sound)Relevant issues from QA Notion:
2. Channel preview fixes
Relevant block in Notion:
useMessagePreviewTextdidn't translate message labels like "Voice Recording (0:05)"3. Mirroring switch in RTL mode
Relevant Notion block:
[RTL] Some issues with Polls screen -> The pointer moves to the wrong direction when user is typing
Added a mirroring to all switch elements (off state is on the right side, instead of left). Questions:
4. Search bar not mirrored in RTL mode
These are changes in the SampleApp:
From Notion: [RTL] Search field is not mirrored, both channel search and user search
Channel search:
User search - I assume this is the new DM screen, but this one seems fine to me without any change:
🎨 UI Changes
🧪 Testing
I only tested on iOS
☑️ Checklist
developbranch