Migrate read-state request bodies to generated models#6550
Draft
gpunto wants to merge 1 commit into
Draft
Conversation
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
Contributor
SDK Size Comparison 📏
|
96c6a70 to
760bea1
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Goal
Migrate the read-state request bodies (
markRead,markUnread) to generated models. Part of the incremental OpenAPI model migration.Part of AND-1291
Implementation
internal MarkReadRequestandMarkUnreadRequestinnetwork.models; delete the hand-written ones. PointChannelApi/MoshiChatApi/tests at them.@Jsonnames preserved (message_id->messageId,message_timestamp->messageTimestamp,thread_id->threadId), so the wire format is unchanged; only positional/named args at the call sites change.markAllReadsends no body, so there is noMarkChannelsReadRequestto migrate here.Testing
spotlessApply,apiDump(no API drift),detekt, andtestDebugUnitTestall pass.markMessageRead->200,markUnread->200.