Skip to content

Add scroll-to-first-unread pill to the message view #6409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andremion merged 14 commits into from
May 5, 2026
Merged

Add scroll-to-first-unread pill to the message view #6409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e2d9ce2
Surface unreadLabel on MessageListState
andremion May 4, 2026
90c01d4
Expose disableUnreadLabelButton on Compose MessageListViewModel
andremion May 4, 2026
413922b
Add ScrollToFirstUnreadButton ChatComponentFactory slot
andremion May 4, 2026
bde8534
Wire scroll-to-first-unread pill into the message view
andremion May 4, 2026
95fc80d
Make unread-label button dismissal sticky against read-state changes
andremion May 4, 2026
527c2f8
Tidy ScrollToFirstUnreadButton: tokenise stroke, simplify modifiers
andremion May 4, 2026
8ca7da5
Document unreadLabelState contract and Compose-friendly alternative
andremion May 4, 2026
b214bf6
Add role to internal Modifier.clickable; reuse in pill
andremion May 4, 2026
f849aac
Add vertical separator between label and close icon in pill
andremion May 4, 2026
e144e48
Test: ScrollToFirstUnreadButton snapshot
andremion May 4, 2026
24667c2
Fix pill preview height and re-target the click testTag
andremion May 4, 2026
c5966ad
Address PR review: visibility key, null-label guard, test strictness
andremion May 4, 2026
80769a2
Test: cover scroll-to-first-unread VM action and wired pill snapshot
andremion May 4, 2026
821ff7f
Move unread separator off-screen in pill snapshot fixture
andremion May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 41 additions & 6 deletions stream-chat-android-compose/api/stream-chat-android-compose.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1516,6 +1516,12 @@ public final class io/getstream/chat/android/compose/ui/components/messages/Comp
public final fun getLambda$-388063089$stream_chat_android_compose_release ()Lkotlin/jvm/functions/Function2;
}

public final class io/getstream/chat/android/compose/ui/components/messages/ComposableSingletons$ScrollToFirstUnreadButtonKt {
public static final field INSTANCE Lio/getstream/chat/android/compose/ui/components/messages/ComposableSingletons$ScrollToFirstUnreadButtonKt;
public fun <init> ()V
public final fun getLambda$-1405339857$stream_chat_android_compose_release ()Lkotlin/jvm/functions/Function2;
}

public final class io/getstream/chat/android/compose/ui/components/messages/ComposableSingletons$SwipeToReplyIconKt {
public static final field INSTANCE Lio/getstream/chat/android/compose/ui/components/messages/ComposableSingletons$SwipeToReplyIconKt;
public fun <init> ()V
Expand Down Expand Up @@ -2091,7 +2097,7 @@ public final class io/getstream/chat/android/compose/ui/messages/list/Composable
public final class io/getstream/chat/android/compose/ui/messages/list/ComposableSingletons$MessagesKt {
public static final field INSTANCE Lio/getstream/chat/android/compose/ui/messages/list/ComposableSingletons$MessagesKt;
public fun <init> ()V
public final fun getLambda$1954099387$stream_chat_android_compose_release ()Lkotlin/jvm/functions/Function3;
public final fun getLambda$203042131$stream_chat_android_compose_release ()Lkotlin/jvm/functions/Function3;
}

public final class io/getstream/chat/android/compose/ui/messages/list/MessageContainerKt {
Expand All @@ -2107,8 +2113,8 @@ public final class io/getstream/chat/android/compose/ui/messages/list/MessageIte
}

public final class io/getstream/chat/android/compose/ui/messages/list/MessageListKt {
public static final fun MessageList (Lio/getstream/chat/android/compose/viewmodel/messages/MessageListViewModel;Landroidx/compose/ui/Modifier;Landroidx/compose/foundation/layout/PaddingValues;Lio/getstream/chat/android/compose/ui/messages/list/MessagesLazyListState;Landroidx/compose/foundation/layout/Arrangement$Vertical;Landroidx/compose/foundation/layout/Arrangement$Vertical;Lkotlin/jvm/functions/Function1;Lkotlin/jvm/functions/Function1;Lkotlin/jvm/functions/Function0;Lkotlin/jvm/functions/Function1;Lkotlin/jvm/functions/Function0;Lkotlin/jvm/functions/Function1;Lkotlin/jvm/functions/Function1;Lkotlin/jvm/functions/Function1;Lkotlin/jvm/functions/Function1;Lkotlin/jvm/functions/Function0;Landroidx/compose/runtime/Composer;III)V
public static final fun MessageList (Lio/getstream/chat/android/ui/common/state/messages/list/MessageListState;Landroidx/compose/foundation/layout/Arrangement$Vertical;Landroidx/compose/foundation/layout/Arrangement$Vertical;Landroidx/compose/ui/Modifier;Landroidx/compose/foundation/layout/PaddingValues;Lio/getstream/chat/android/compose/ui/messages/list/MessagesLazyListState;Lkotlin/jvm/functions/Function0;Lkotlin/jvm/functions/Function1;Lkotlin/jvm/functions/Function0;Lkotlin/jvm/functions/Function1;Lkotlin/jvm/functions/Function1;Lkotlin/jvm/functions/Function0;Lkotlin/jvm/functions/Function1;Landroidx/compose/runtime/Composer;III)V
public static final fun MessageList (Lio/getstream/chat/android/compose/viewmodel/messages/MessageListViewModel;Landroidx/compose/ui/Modifier;Landroidx/compose/foundation/layout/PaddingValues;Lio/getstream/chat/android/compose/ui/messages/list/MessagesLazyListState;Landroidx/compose/foundation/layout/Arrangement$Vertical;Landroidx/compose/foundation/layout/Arrangement$Vertical;Lkotlin/jvm/functions/Function1;Lkotlin/jvm/functions/Function1;Lkotlin/jvm/functions/Function0;Lkotlin/jvm/functions/Function1;Lkotlin/jvm/functions/Function0;Lkotlin/jvm/functions/Function1;Lkotlin/jvm/functions/Function1;Lkotlin/jvm/functions/Function1;Lkotlin/jvm/functions/Function1;Lkotlin/jvm/functions/Function0;Lkotlin/jvm/functions/Function0;Lkotlin/jvm/functions/Function0;Landroidx/compose/runtime/Composer;III)V
public static final fun MessageList (Lio/getstream/chat/android/ui/common/state/messages/list/MessageListState;Landroidx/compose/foundation/layout/Arrangement$Vertical;Landroidx/compose/foundation/layout/Arrangement$Vertical;Landroidx/compose/ui/Modifier;Landroidx/compose/foundation/layout/PaddingValues;Lio/getstream/chat/android/compose/ui/messages/list/MessagesLazyListState;Lkotlin/jvm/functions/Function0;Lkotlin/jvm/functions/Function1;Lkotlin/jvm/functions/Function0;Lkotlin/jvm/functions/Function1;Lkotlin/jvm/functions/Function1;Lkotlin/jvm/functions/Function0;Lkotlin/jvm/functions/Function0;Lkotlin/jvm/functions/Function0;Lkotlin/jvm/functions/Function1;Landroidx/compose/runtime/Composer;III)V
}

public final class io/getstream/chat/android/compose/ui/messages/list/MessagesLazyListState {
Expand Down Expand Up @@ -3456,6 +3462,7 @@ public abstract interface class io/getstream/chat/android/compose/ui/theme/ChatC
public fun ReactionsMenu (Lio/getstream/chat/android/compose/ui/theme/ReactionsMenuParams;Landroidx/compose/runtime/Composer;I)V
public fun ReactionsMenuContent (Lio/getstream/chat/android/compose/ui/theme/ReactionsMenuContentParams;Landroidx/compose/runtime/Composer;I)V
public fun ScrollToBottomButton (Lio/getstream/chat/android/compose/ui/theme/ScrollToBottomButtonParams;Landroidx/compose/runtime/Composer;I)V
public fun ScrollToFirstUnreadButton (Lio/getstream/chat/android/compose/ui/theme/ScrollToFirstUnreadButtonParams;Landroidx/compose/runtime/Composer;I)V
Comment thread
andremion marked this conversation as resolved.
public fun SearchInputClearButton (Lio/getstream/chat/android/compose/ui/theme/SearchInputClearButtonParams;Landroidx/compose/runtime/Composer;I)V
public fun SearchInputLabel (Lio/getstream/chat/android/compose/ui/theme/SearchInputLabelParams;Landroidx/compose/runtime/Composer;I)V
public fun SearchInputLeadingIcon (Landroidx/compose/foundation/layout/RowScope;Lio/getstream/chat/android/compose/ui/theme/SearchInputLeadingIconParams;Landroidx/compose/runtime/Composer;I)V
Expand Down Expand Up @@ -3645,6 +3652,7 @@ public final class io/getstream/chat/android/compose/ui/theme/ChatComponentFacto
public static fun ReactionsMenu (Lio/getstream/chat/android/compose/ui/theme/ChatComponentFactory;Lio/getstream/chat/android/compose/ui/theme/ReactionsMenuParams;Landroidx/compose/runtime/Composer;I)V
public static fun ReactionsMenuContent (Lio/getstream/chat/android/compose/ui/theme/ChatComponentFactory;Lio/getstream/chat/android/compose/ui/theme/ReactionsMenuContentParams;Landroidx/compose/runtime/Composer;I)V
public static fun ScrollToBottomButton (Lio/getstream/chat/android/compose/ui/theme/ChatComponentFactory;Lio/getstream/chat/android/compose/ui/theme/ScrollToBottomButtonParams;Landroidx/compose/runtime/Composer;I)V
public static fun ScrollToFirstUnreadButton (Lio/getstream/chat/android/compose/ui/theme/ChatComponentFactory;Lio/getstream/chat/android/compose/ui/theme/ScrollToFirstUnreadButtonParams;Landroidx/compose/runtime/Composer;I)V
public static fun SearchInputClearButton (Lio/getstream/chat/android/compose/ui/theme/ChatComponentFactory;Lio/getstream/chat/android/compose/ui/theme/SearchInputClearButtonParams;Landroidx/compose/runtime/Composer;I)V
public static fun SearchInputLabel (Lio/getstream/chat/android/compose/ui/theme/ChatComponentFactory;Lio/getstream/chat/android/compose/ui/theme/SearchInputLabelParams;Landroidx/compose/runtime/Composer;I)V
public static fun SearchInputLeadingIcon (Lio/getstream/chat/android/compose/ui/theme/ChatComponentFactory;Landroidx/compose/foundation/layout/RowScope;Lio/getstream/chat/android/compose/ui/theme/SearchInputLeadingIconParams;Landroidx/compose/runtime/Composer;I)V
Expand Down Expand Up @@ -5155,18 +5163,23 @@ public final class io/getstream/chat/android/compose/ui/theme/MessageListEmptyTh

public final class io/getstream/chat/android/compose/ui/theme/MessageListHelperContentParams {
public static final field $stable I
public fun <init> (Lio/getstream/chat/android/ui/common/state/messages/list/MessageListState;Lio/getstream/chat/android/compose/ui/messages/list/MessagesLazyListState;Landroidx/compose/foundation/layout/PaddingValues;Lkotlin/jvm/functions/Function1;)V
public fun <init> (Lio/getstream/chat/android/ui/common/state/messages/list/MessageListState;Lio/getstream/chat/android/compose/ui/messages/list/MessagesLazyListState;Landroidx/compose/foundation/layout/PaddingValues;Lkotlin/jvm/functions/Function1;Lkotlin/jvm/functions/Function0;Lkotlin/jvm/functions/Function0;)V
public synthetic fun <init> (Lio/getstream/chat/android/ui/common/state/messages/list/MessageListState;Lio/getstream/chat/android/compose/ui/messages/list/MessagesLazyListState;Landroidx/compose/foundation/layout/PaddingValues;Lkotlin/jvm/functions/Function1;Lkotlin/jvm/functions/Function0;Lkotlin/jvm/functions/Function0;ILkotlin/jvm/internal/DefaultConstructorMarker;)V
public final fun component1 ()Lio/getstream/chat/android/ui/common/state/messages/list/MessageListState;
public final fun component2 ()Lio/getstream/chat/android/compose/ui/messages/list/MessagesLazyListState;
public final fun component3 ()Landroidx/compose/foundation/layout/PaddingValues;
public final fun component4 ()Lkotlin/jvm/functions/Function1;
public final fun copy (Lio/getstream/chat/android/ui/common/state/messages/list/MessageListState;Lio/getstream/chat/android/compose/ui/messages/list/MessagesLazyListState;Landroidx/compose/foundation/layout/PaddingValues;Lkotlin/jvm/functions/Function1;)Lio/getstream/chat/android/compose/ui/theme/MessageListHelperContentParams;
public static synthetic fun copy$default (Lio/getstream/chat/android/compose/ui/theme/MessageListHelperContentParams;Lio/getstream/chat/android/ui/common/state/messages/list/MessageListState;Lio/getstream/chat/android/compose/ui/messages/list/MessagesLazyListState;Landroidx/compose/foundation/layout/PaddingValues;Lkotlin/jvm/functions/Function1;ILjava/lang/Object;)Lio/getstream/chat/android/compose/ui/theme/MessageListHelperContentParams;
public final fun component5 ()Lkotlin/jvm/functions/Function0;
public final fun component6 ()Lkotlin/jvm/functions/Function0;
public final fun copy (Lio/getstream/chat/android/ui/common/state/messages/list/MessageListState;Lio/getstream/chat/android/compose/ui/messages/list/MessagesLazyListState;Landroidx/compose/foundation/layout/PaddingValues;Lkotlin/jvm/functions/Function1;Lkotlin/jvm/functions/Function0;Lkotlin/jvm/functions/Function0;)Lio/getstream/chat/android/compose/ui/theme/MessageListHelperContentParams;
public static synthetic fun copy$default (Lio/getstream/chat/android/compose/ui/theme/MessageListHelperContentParams;Lio/getstream/chat/android/ui/common/state/messages/list/MessageListState;Lio/getstream/chat/android/compose/ui/messages/list/MessagesLazyListState;Landroidx/compose/foundation/layout/PaddingValues;Lkotlin/jvm/functions/Function1;Lkotlin/jvm/functions/Function0;Lkotlin/jvm/functions/Function0;ILjava/lang/Object;)Lio/getstream/chat/android/compose/ui/theme/MessageListHelperContentParams;
public fun equals (Ljava/lang/Object;)Z
public final fun getContentPadding ()Landroidx/compose/foundation/layout/PaddingValues;
public final fun getMessageListState ()Lio/getstream/chat/android/ui/common/state/messages/list/MessageListState;
public final fun getMessagesLazyListState ()Lio/getstream/chat/android/compose/ui/messages/list/MessagesLazyListState;
public final fun getOnDismissUnreadLabel ()Lkotlin/jvm/functions/Function0;
public final fun getOnScrollToBottomClick ()Lkotlin/jvm/functions/Function1;
public final fun getOnScrollToFirstUnreadClick ()Lkotlin/jvm/functions/Function0;
public fun hashCode ()I
public fun toString ()Ljava/lang/String;
}
Expand Down Expand Up @@ -5683,6 +5696,27 @@ public final class io/getstream/chat/android/compose/ui/theme/ScrollToBottomButt
public fun toString ()Ljava/lang/String;
}

public final class io/getstream/chat/android/compose/ui/theme/ScrollToFirstUnreadButtonParams {
public static final field $stable I
public fun <init> (ZILkotlin/jvm/functions/Function0;Lkotlin/jvm/functions/Function0;Landroidx/compose/ui/Modifier;)V
public synthetic fun <init> (ZILkotlin/jvm/functions/Function0;Lkotlin/jvm/functions/Function0;Landroidx/compose/ui/Modifier;ILkotlin/jvm/internal/DefaultConstructorMarker;)V
public final fun component1 ()Z
public final fun component2 ()I
public final fun component3 ()Lkotlin/jvm/functions/Function0;
public final fun component4 ()Lkotlin/jvm/functions/Function0;
public final fun component5 ()Landroidx/compose/ui/Modifier;
public final fun copy (ZILkotlin/jvm/functions/Function0;Lkotlin/jvm/functions/Function0;Landroidx/compose/ui/Modifier;)Lio/getstream/chat/android/compose/ui/theme/ScrollToFirstUnreadButtonParams;
public static synthetic fun copy$default (Lio/getstream/chat/android/compose/ui/theme/ScrollToFirstUnreadButtonParams;ZILkotlin/jvm/functions/Function0;Lkotlin/jvm/functions/Function0;Landroidx/compose/ui/Modifier;ILjava/lang/Object;)Lio/getstream/chat/android/compose/ui/theme/ScrollToFirstUnreadButtonParams;
public fun equals (Ljava/lang/Object;)Z
public final fun getModifier ()Landroidx/compose/ui/Modifier;
public final fun getOnClick ()Lkotlin/jvm/functions/Function0;
public final fun getOnDismiss ()Lkotlin/jvm/functions/Function0;
public final fun getUnreadCount ()I
public final fun getVisible ()Z
public fun hashCode ()I
public fun toString ()Ljava/lang/String;
}

public final class io/getstream/chat/android/compose/ui/theme/SearchInputClearButtonParams {
public static final field $stable I
public fun <init> (Lkotlin/jvm/functions/Function0;)V
Expand Down Expand Up @@ -6776,6 +6810,7 @@ public final class io/getstream/chat/android/compose/viewmodel/messages/MessageL
public final fun deleteMessage (Lio/getstream/chat/android/models/Message;)V
public final fun deleteMessage (Lio/getstream/chat/android/models/Message;Z)V
public static synthetic fun deleteMessage$default (Lio/getstream/chat/android/compose/viewmodel/messages/MessageListViewModel;Lio/getstream/chat/android/models/Message;ZILjava/lang/Object;)V
public final fun disableUnreadLabelButton ()V
public final fun dismissAllMessageActions ()V
public final fun dismissMessageAction (Lio/getstream/chat/android/ui/common/state/messages/MessageAction;)V
public final fun displayPollMoreOptions (Lio/getstream/chat/android/ui/common/state/messages/poll/SelectedPoll;)V
Expand Down
2 changes: 1 addition & 1 deletion ...ava/io/getstream/chat/android/compose/ui/attachments/preview/internal/MediaGalleryPage.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ internal fun MediaGalleryVideoPage(
MediaThumbnail(
modifier = Modifier
.matchParentSize()
.clickable {
.clickable(bounded = true) {
Comment thread
gpunto marked this conversation as resolved.
showThumbnail = false
player.play()
},
Expand Down
2 changes: 1 addition & 1 deletion .../getstream/chat/android/compose/ui/attachments/preview/internal/MediaGalleryPhotosMenu.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ private fun MediaGalleryPhotosMenuItem(
modifier = Modifier
.fillMaxWidth()
.aspectRatio(1f)
.clickable { onClick() },
.clickable(bounded = true) { onClick() },
contentAlignment = Alignment.Center,
) {
val data = attachment.imagePreviewData
Expand Down
Loading
Loading