Fix/dhi 141599

[BotellaA]

No description provided.

[github-actions]

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 3 concern(s)

• src/geode/geometry/basic_objects/polygon.cpp:274:52: warning: [readability-function-cognitive-complexity]

  function 'minimum_height' has cognitive complexity of 11 (threshold 10)

    274 |     double GenericPolygon< PointType, dimension >::minimum_height() const
        |                                                    ^
  /__w/OpenGeode/OpenGeode/src/geode/geometry/basic_objects/polygon.cpp:279:9: note: +1, including nesting penalty of 0, nesting level increased to 1
    279 |         for( const auto e : geode::Range{ nb_vertices } )
        |         ^
  /__w/OpenGeode/OpenGeode/src/geode/geometry/basic_objects/polygon.cpp:283:48: note: +2, including nesting penalty of 1, nesting level increased to 2
    283 |                 vertices_[e == nb_vertices - 1 ? 0 : e + 1];
        |                                                ^
  /__w/OpenGeode/OpenGeode/src/geode/geometry/basic_objects/polygon.cpp:286:13: note: +2, including nesting penalty of 1, nesting level increased to 2
    286 |             if( cur_length > max_length )
        |             ^
  /__w/OpenGeode/OpenGeode/src/geode/geometry/basic_objects/polygon.cpp:292:9: note: +1, including nesting penalty of 0, nesting level increased to 1
    292 |         if( max_length < GLOBAL_EPSILON )
        |         ^
  /__w/OpenGeode/OpenGeode/src/geode/geometry/basic_objects/polygon.cpp:297:48: note: +1, including nesting penalty of 0, nesting level increased to 1
    297 |             max_length_edge + 1 == nb_vertices ? 0 : max_length_edge + 1;
        |                                                ^
  /__w/OpenGeode/OpenGeode/src/geode/geometry/basic_objects/polygon.cpp:303:9: note: +1, including nesting penalty of 0, nesting level increased to 1
    303 |         for( const auto vertex : geode::Range{ nb_vertices } )
        |         ^
  /__w/OpenGeode/OpenGeode/src/geode/geometry/basic_objects/polygon.cpp:305:13: note: +2, including nesting penalty of 1, nesting level increased to 2
    305 |             if( vertex == max_length_edge || vertex == next )
        |             ^
  /__w/OpenGeode/OpenGeode/src/geode/geometry/basic_objects/polygon.cpp:305:43: note: +1
    305 |             if( vertex == max_length_edge || vertex == next )
        |                                           ^

• src/geode/model/helpers/component_mesh_edges.cpp:127:51: warning: [readability-function-cognitive-complexity]

  function 'line_component_mesh_edges' has cognitive complexity of 13 (threshold 10)

    127 |         geode::ModelComponentMeshEdges::LineEdges line_component_mesh_edges(
        |                                                   ^
  /__w/OpenGeode/OpenGeode/src/geode/model/helpers/component_mesh_edges.cpp:131:13: note: +1, including nesting penalty of 0, nesting level increased to 1
    131 |             if( edge_unique_vertices[0] == NO_ID
        |             ^
  /__w/OpenGeode/OpenGeode/src/geode/model/helpers/component_mesh_edges.cpp:132:17: note: +1
    132 |                 || edge_unique_vertices[1] == NO_ID )
        |                 ^
  /__w/OpenGeode/OpenGeode/src/geode/model/helpers/component_mesh_edges.cpp:139:13: note: +1, including nesting penalty of 0, nesting level increased to 1
    139 |             if( line_pairs.empty() )
        |             ^
  /__w/OpenGeode/OpenGeode/src/geode/model/helpers/component_mesh_edges.cpp:145:13: note: +1, including nesting penalty of 0, nesting level increased to 1
    145 |             for( const auto& line_pair : line_pairs )
        |             ^
  /__w/OpenGeode/OpenGeode/src/geode/model/helpers/component_mesh_edges.cpp:149:17: note: +2, including nesting penalty of 1, nesting level increased to 2
    149 |                 for( const auto& pair : line_pair.second )
        |                 ^
  /__w/OpenGeode/OpenGeode/src/geode/model/helpers/component_mesh_edges.cpp:151:21: note: +3, including nesting penalty of 2, nesting level increased to 3
    151 |                     for( const auto& edge_vertex :
        |                     ^
  /__w/OpenGeode/OpenGeode/src/geode/model/helpers/component_mesh_edges.cpp:156:25: note: +4, including nesting penalty of 3, nesting level increased to 4
    156 |                         if( opposite_vertex == pair[1] )
        |                         ^

• src/geode/model/helpers/component_mesh_edges.cpp:205:13: warning: [readability-function-cognitive-complexity]

  function 'surface_component_mesh_edges' has cognitive complexity of 12 (threshold 10)

    205 |             surface_component_mesh_edges( const Model& model,
        |             ^
  /__w/OpenGeode/OpenGeode/src/geode/model/helpers/component_mesh_edges.cpp:208:13: note: +1, including nesting penalty of 0, nesting level increased to 1
    208 |             if( edge_unique_vertices[0] == NO_ID
        |             ^
  /__w/OpenGeode/OpenGeode/src/geode/model/helpers/component_mesh_edges.cpp:209:17: note: +1
    209 |                 || edge_unique_vertices[1] == NO_ID )
        |                 ^
  /__w/OpenGeode/OpenGeode/src/geode/model/helpers/component_mesh_edges.cpp:216:13: note: +1, including nesting penalty of 0, nesting level increased to 1
    216 |             if( surface_pairs.empty() )
        |             ^
  /__w/OpenGeode/OpenGeode/src/geode/model/helpers/component_mesh_edges.cpp:222:13: note: +1, including nesting penalty of 0, nesting level increased to 1
    222 |             for( const auto& [surface_id, edge_pairs] : surface_pairs )
        |             ^
  /__w/OpenGeode/OpenGeode/src/geode/model/helpers/component_mesh_edges.cpp:226:17: note: +2, including nesting penalty of 1, nesting level increased to 2
    226 |                 for( const auto& pair : edge_pairs )
        |                 ^
  /__w/OpenGeode/OpenGeode/src/geode/model/helpers/component_mesh_edges.cpp:228:21: note: +3, including nesting penalty of 2, nesting level increased to 3
    228 |                     if( auto edge = mesh.polygon_edge_from_vertices(
        |                     ^
  /__w/OpenGeode/OpenGeode/src/geode/model/helpers/component_mesh_edges.cpp:235:21: note: +3, including nesting penalty of 2, nesting level increased to 3
    235 |                     if( auto edge = mesh.polygon_edge_from_vertices(
        |                     ^

Have any feedback or feature suggestions? Share it here.

[BotellaA]

🎉 This PR is included in version 17.4.1-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[BotellaA]

🎉 This PR is included in version 17.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀