fix(Tuple): remove std::make_pair and std::make_tuple by BenPinet · Pull Request #194 · Geode-solutions/OpenGeode-Inspector

BenPinet · 2026-08-06T12:11:03Z

No description provided.

github-actions · 2026-08-06T12:13:38Z

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 41 concern(s)

src/geode/inspector/inspection/criterion/internal/component_meshes_degeneration.cpp:40:1: warning: [modernize-concat-nested-namespaces]

   40 | namespace geode
      | ^~~~~~~~~~~~~~~
   41 | {
      | ~
   42 |     namespace internal
      |     ~~~~~~~~~~~~~~~~~~
      |     namespace geode::internal

src/geode/inspector/inspection/criterion/manifold/surface_edge_manifold.cpp:80:9: warning: [google-explicit-constructor]

single-argument constructors must be marked explicit to avoid unintentional implicit conversions
```
   80 |         Impl( const SurfaceMesh< dimension >& mesh ) : mesh_( mesh ) {}
      |         ^
      |         explicit 
```
src/geode/inspector/inspection/criterion/manifold/surface_edge_manifold.cpp:82:9: warning: [modernize-use-nodiscard]

function 'mesh_edges_are_manifold' should be marked [[nodiscard]]
```
   82 |         bool mesh_edges_are_manifold() const
      |         ^
      |         [[nodiscard]] 
```
src/geode/inspector/inspection/criterion/manifold/surface_edge_manifold.cpp:99:9: warning: [modernize-use-nodiscard]

function 'non_manifold_edges' should be marked [[nodiscard]]
```
   99 |         InspectionIssues< std::array< index_t, 2 > > non_manifold_edges() const
      |         ^
      |         [[nodiscard]] 
```

src/geode/inspector/inspection/topology/internal/expected_nb_cmvs.cpp:93:9: warning: [readability-function-cognitive-complexity]

   93 |         expected_block_cmvs_and_error( const geode::BRep& brep,
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/internal/expected_nb_cmvs.cpp:99:44: note: nesting level increased to 1
   99 |             unique_vertex_cmvs.block_cmvs, [&block_uuid]( const auto& cmv ) {
      |                                            ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/internal/expected_nb_cmvs.cpp:105:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  105 |         for( const auto& cmv : unique_vertex_cmvs.surface_cmvs )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/internal/expected_nb_cmvs.cpp:107:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  107 |             if( brep.is_boundary(
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/internal/expected_nb_cmvs.cpp:112:18: note: +1, nesting level increased to 2
  112 |             else if( brep.is_internal(
      |                  ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/internal/expected_nb_cmvs.cpp:124:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  124 |         for( const auto& cmv : unique_vertex_cmvs.line_cmvs )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/internal/expected_nb_cmvs.cpp:127:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  127 |             if( brep.nb_embedding_blocks( cmv_line ) != 0 )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/internal/expected_nb_cmvs.cpp:133:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  133 |             if( boundary_count > 0 )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/internal/expected_nb_cmvs.cpp:136:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  136 |                 if( boundary_count > 1 )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/internal/expected_nb_cmvs.cpp:143:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  143 |             if( brep.nb_embedding_surfaces( cmv_line ) > 0 )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/internal/expected_nb_cmvs.cpp:145:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  145 |                 for( const auto& incident_surface :
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/internal/expected_nb_cmvs.cpp:148:21: note: +4, including nesting penalty of 3, nesting level increased to 4
  148 |                     if( brep.is_internal( incident_surface, block ) )
      |                     ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/internal/expected_nb_cmvs.cpp:156:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  156 |             if( !line_is_inside_block( brep, cmv_line, block ) )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/internal/expected_nb_cmvs.cpp:160:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  160 |             if( brep.nb_incidences( cmv.component_id.id() ) == 1 )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/internal/expected_nb_cmvs.cpp:168:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  168 |         if( nb_boundary_surface_cmvs > 0 )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/internal/expected_nb_cmvs.cpp:178:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  178 |         if( nb_line_cmvs_to_remove != 0 || nb_line_on_boundary_cmvs != 0 )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/internal/expected_nb_cmvs.cpp:178:41: note: +1
  178 |         if( nb_line_cmvs_to_remove != 0 || nb_line_on_boundary_cmvs != 0 )
      |                                         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/internal/expected_nb_cmvs.cpp:183:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  183 |         if( nb_lines_on_several_boundaries % 2 == 1 )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/internal/expected_nb_cmvs.cpp:197:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  197 |             if( nb_block_cmvs
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/internal/expected_nb_cmvs.cpp:205:17: note: +1, including nesting penalty of 0, nesting level increased to 1
  205 |                 ? std::nullopt
      |                 ^

src/geode/inspector/inspection/topology/internal/expected_nb_cmvs.cpp:234:1: warning: [modernize-concat-nested-namespaces]

  234 | namespace geode
      | ^~~~~~~~~~~~~~~
  235 | {
      | ~
  236 |     namespace internal
      |     ~~~~~~~~~~~~~~~~~~
      |     namespace geode::internal

tests/inspection/test-surface-intersections.cpp:33:6: warning: [misc-use-internal-linkage]

function 'check_intersections2D' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   33 | void check_intersections2D()
      |      ^
      | static 
```
tests/inspection/test-surface-intersections.cpp:33:6: warning: [readability-identifier-naming]

invalid case style for global function 'check_intersections2D'
```
   33 | void check_intersections2D()
      |      ^~~~~~~~~~~~~~~~~~~~~
      |      check_intersections2_d
```
tests/inspection/test-surface-intersections.cpp:37:31: warning: [cppcoreguidelines-avoid-magic-numbers]

5 is a magic number; consider replacing it with a named constant
```
   37 |     builder->create_vertices( 5 );
      |                               ^
```
tests/inspection/test-surface-intersections.cpp:39:46: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   39 |     builder->set_point( 1, geode::Point2D{ { 3., 0. } } );
      |                                              ^
```
tests/inspection/test-surface-intersections.cpp:40:50: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   40 |     builder->set_point( 2, geode::Point2D{ { 0., 4. } } );
      |                                                  ^
```
tests/inspection/test-surface-intersections.cpp:41:46: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   41 |     builder->set_point( 3, geode::Point2D{ { 3., 4. } } );
      |                                              ^
```
tests/inspection/test-surface-intersections.cpp:41:50: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   41 |     builder->set_point( 3, geode::Point2D{ { 3., 4. } } );
      |                                                  ^
```
tests/inspection/test-surface-intersections.cpp:42:51: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   42 |     builder->set_point( 4, geode::Point2D{ { -1., 2. } } );
      |                                                   ^
```

tests/inspection/test-surface-intersections.cpp:62:58: warning: [hicpp-uppercase-literal-suffix]

   62 |             std::pair< geode::index_t, geode::index_t >{ 2u, 0u } )
      |                                                          ^~
      |                                                           U

tests/inspection/test-surface-intersections.cpp:62:62: warning: [hicpp-uppercase-literal-suffix]

   62 |             std::pair< geode::index_t, geode::index_t >{ 2u, 0u } )
      |                                                              ^~
      |                                                               U

tests/inspection/test-surface-intersections.cpp:68:58: warning: [hicpp-uppercase-literal-suffix]

   68 |             std::pair< geode::index_t, geode::index_t >{ 2u, 1u } )
      |                                                          ^~
      |                                                           U

tests/inspection/test-surface-intersections.cpp:68:62: warning: [hicpp-uppercase-literal-suffix]

   68 |             std::pair< geode::index_t, geode::index_t >{ 2u, 1u } )
      |                                                              ^~
      |                                                               U

tests/inspection/test-surface-intersections.cpp:74:58: warning: [hicpp-uppercase-literal-suffix]

   74 |             std::pair< geode::index_t, geode::index_t >{ 0u, 1u } )
      |                                                          ^~
      |                                                           U

tests/inspection/test-surface-intersections.cpp:74:62: warning: [hicpp-uppercase-literal-suffix]

   74 |             std::pair< geode::index_t, geode::index_t >{ 0u, 1u } )
      |                                                              ^~
      |                                                               U

tests/inspection/test-surface-intersections.cpp:83:6: warning: [misc-use-internal-linkage]

function 'check_intersections3D' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   83 | void check_intersections3D()
      |      ^
      | static 
```
tests/inspection/test-surface-intersections.cpp:83:6: warning: [readability-identifier-naming]

invalid case style for global function 'check_intersections3D'
```
   83 | void check_intersections3D()
      |      ^~~~~~~~~~~~~~~~~~~~~
      |      check_intersections3_d
```
tests/inspection/test-surface-intersections.cpp:87:31: warning: [cppcoreguidelines-avoid-magic-numbers]

7 is a magic number; consider replacing it with a named constant
```
   87 |     builder->create_vertices( 7 );
      |                               ^
```
tests/inspection/test-surface-intersections.cpp:89:54: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   89 |     builder->set_point( 1, geode::Point3D{ { 0., 0., 3. } } );
      |                                                      ^
```
tests/inspection/test-surface-intersections.cpp:90:50: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   90 |     builder->set_point( 2, geode::Point3D{ { 0., 2., 0. } } );
      |                                                  ^
```
tests/inspection/test-surface-intersections.cpp:91:46: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   91 |     builder->set_point( 3, geode::Point3D{ { 2., 0., 0. } } );
      |                                              ^
```
tests/inspection/test-surface-intersections.cpp:92:46: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   92 |     builder->set_point( 4, geode::Point3D{ { 5., 0., 1.5 } } );
      |                                              ^
```
tests/inspection/test-surface-intersections.cpp:92:54: warning: [cppcoreguidelines-avoid-magic-numbers]

1.5 is a magic number; consider replacing it with a named constant
```
   92 |     builder->set_point( 4, geode::Point3D{ { 5., 0., 1.5 } } );
      |                                                      ^
```
tests/inspection/test-surface-intersections.cpp:93:25: warning: [cppcoreguidelines-avoid-magic-numbers]

5 is a magic number; consider replacing it with a named constant
```
   93 |     builder->set_point( 5, geode::Point3D{ { 2., 0.5, 2. } } );
      |                         ^
```
tests/inspection/test-surface-intersections.cpp:93:46: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   93 |     builder->set_point( 5, geode::Point3D{ { 2., 0.5, 2. } } );
      |                                              ^
```
tests/inspection/test-surface-intersections.cpp:93:50: warning: [cppcoreguidelines-avoid-magic-numbers]

0.5 is a magic number; consider replacing it with a named constant
```
   93 |     builder->set_point( 5, geode::Point3D{ { 2., 0.5, 2. } } );
      |                                                  ^
```
tests/inspection/test-surface-intersections.cpp:93:55: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   93 |     builder->set_point( 5, geode::Point3D{ { 2., 0.5, 2. } } );
      |                                                       ^
```
tests/inspection/test-surface-intersections.cpp:94:25: warning: [cppcoreguidelines-avoid-magic-numbers]

6 is a magic number; consider replacing it with a named constant
```
   94 |     builder->set_point( 6, geode::Point3D{ { 0., 0., 1.5 } } );
      |                         ^
```
tests/inspection/test-surface-intersections.cpp:94:54: warning: [cppcoreguidelines-avoid-magic-numbers]

1.5 is a magic number; consider replacing it with a named constant
```
   94 |     builder->set_point( 6, geode::Point3D{ { 0., 0., 1.5 } } );
      |                                                      ^
```
tests/inspection/test-surface-intersections.cpp:97:36: warning: [cppcoreguidelines-avoid-magic-numbers]

5 is a magic number; consider replacing it with a named constant
```
   97 |     builder->create_triangle( { 3, 5, 2 } );
      |                                    ^
```
tests/inspection/test-surface-intersections.cpp:98:33: warning: [cppcoreguidelines-avoid-magic-numbers]

5 is a magic number; consider replacing it with a named constant
```
   98 |     builder->create_triangle( { 5, 2, 4 } );
      |                                 ^
```
tests/inspection/test-surface-intersections.cpp:99:39: warning: [cppcoreguidelines-avoid-magic-numbers]

6 is a magic number; consider replacing it with a named constant
```
   99 |     builder->create_triangle( { 4, 2, 6 } );
      |                                       ^
```

tests/inspection/test-surface-intersections.cpp:119:58: warning: [hicpp-uppercase-literal-suffix]

  119 |             std::pair< geode::index_t, geode::index_t >{ 0u, 4u } )
      |                                                          ^~
      |                                                           U

tests/inspection/test-surface-intersections.cpp:119:62: warning: [hicpp-uppercase-literal-suffix]

  119 |             std::pair< geode::index_t, geode::index_t >{ 0u, 4u } )
      |                                                              ^~
      |                                                               U

tests/inspection/test-surface-intersections.cpp:125:58: warning: [hicpp-uppercase-literal-suffix]

  125 |             std::pair< geode::index_t, geode::index_t >{ 2u, 4u } )
      |                                                          ^~
      |                                                           U

tests/inspection/test-surface-intersections.cpp:125:62: warning: [hicpp-uppercase-literal-suffix]

  125 |             std::pair< geode::index_t, geode::index_t >{ 2u, 4u } )
      |                                                              ^~
      |                                                               U

Have any feedback or feature suggestions? Share it here.

fix(Tuple): remove std::make_pair and std::make_tuple

f558e7c

BenPinet requested a review from BotellaA August 6, 2026 12:11

BotellaA approved these changes Aug 6, 2026

View reviewed changes

Navigation Menu

Uh oh!

fix(Tuple): remove std::make_pair and std::make_tuple - #194

fix(Tuple): remove std::make_pair and std::make_tuple#194
BenPinet wants to merge 1 commit into
v18from
fix/remove_make_pair_and_tuple

BenPinet commented Aug 6, 2026

Uh oh!

github-actions Bot commented Aug 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

BenPinet commented Aug 6, 2026

Uh oh!

github-actions Bot commented Aug 6, 2026

Cpp-Linter Report ⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants