Skip to content

fix(SIGN): rename signe struct #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BotellaA merged 2 commits into from
Aug 4, 2026
Merged

fix(SIGN): rename signe struct #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e55cf9b
fix(SIGN): rename signe struct
BenPinet Aug 3, 2026
25bba73
Merge branch 'v18' into feat/put_sign_struct_in_caps
BenPinet Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/geode/inspector/inspection/criterion/negative_elements/solid_negative_elements.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ namespace geode
mesh_.polyhedron_vertex( { polyhedron_id, 2 } ) ),
mesh_.point(
mesh_.polyhedron_vertex( { polyhedron_id, 3 } ) ) };
return tetrahedron_volume_sign( tetrahedron ) == Sign::negative;
return tetrahedron_volume_sign( tetrahedron ) == SIGN::negative;
}
return mesh_.polyhedron_volume( polyhedron_id ) < 0;
}
Expand Down
4 changes: 2 additions & 2 deletions src/geode/inspector/inspection/criterion/negative_elements/surface_negative_elements.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ namespace geode
for( const auto polygon_id : Range{ mesh_.nb_polygons() } )
{
if( polygon_area_sign( mesh_.polygon( polygon_id ) )
== Sign::negative )
== SIGN::negative )
{
return true;
}
Expand All @@ -68,7 +68,7 @@ namespace geode
for( const auto polygon_id : Range{ mesh_.nb_polygons() } )
{
if( polygon_area_sign( mesh_.polygon( polygon_id ) )
== Sign::negative )
== SIGN::negative )
{
wrong_polygons.add_issue( polygon_id,
absl::StrCat( "negative polygon ", polygon_id ) );
Expand Down
Loading