Skip to content

fix(Tuple): remove std::make_pair and std::make_tuple #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BenPinet wants to merge 1 commit into
base: v18
Choose a base branch
from
Open

fix(Tuple): remove std::make_pair and std::make_tuple #201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/geode/io/model/msh_input.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@
using boundary_incidences_relations = absl::flat_hash_map< geode::uuid,
absl::flat_hash_set< geode::uuid > >;

void build_topology()

Check warning on line 118 in src/geode/io/model/msh_input.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

src/geode/io/model/msh_input.cpp:118:14 [readability-function-cognitive-complexity] 

function 'build_topology' has cognitive complexity of 13 (threshold 10)
{
if( version() == 4
&& ( absl::c_find( sections_, "$Entities" )
Expand All @@ -126,7 +126,7 @@
boundary_incidences_relations corner_line_relations;
boundary_incidences_relations line_surface_relations;
boundary_incidences_relations surface_block_relations;
for( const auto uv : geode::Range{ brep_.nb_unique_vertices() } )

Check warning on line 129 in src/geode/io/model/msh_input.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

src/geode/io/model/msh_input.cpp:129:29 [readability-identifier-length] 

variable name 'uv' is too short, expected at least 3 characters
{
const auto cmv = get_component_mesh_vertices( uv );
add_potential_relationships( std::get< 0 >( cmv ),
Expand All @@ -136,7 +136,7 @@
add_potential_relationships( std::get< 2 >( cmv ),
std::get< 3 >( cmv ), surface_block_relations );
}
for( const auto uv : geode::Range{ brep_.nb_unique_vertices() } )

Check warning on line 139 in src/geode/io/model/msh_input.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

src/geode/io/model/msh_input.cpp:139:29 [readability-identifier-length] 

variable name 'uv' is too short, expected at least 3 characters
{
const auto cmv = get_component_mesh_vertices( uv );
filter_potential_relationships( std::get< 0 >( cmv ),
Expand Down Expand Up @@ -296,7 +296,7 @@
// TODO physical tags
const auto nb_physical_tags =
geode::string_to_index( tokens.at( 7 ) );
for( const auto b : geode::Range{ geode::string_to_index(

Check warning on line 299 in src/geode/io/model/msh_input.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

src/geode/io/model/msh_input.cpp:299:33 [readability-identifier-length] 

variable name 'b' is too short, expected at least 3 characters
tokens.at( 8 + nb_physical_tags ) ) } )
{
const auto boundary_msh_id =
Expand All @@ -312,7 +312,7 @@
}
}

void create_surfaces( const geode::index_t nb_surfaces )

Check warning on line 315 in src/geode/io/model/msh_input.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

src/geode/io/model/msh_input.cpp:315:14 [readability-function-cognitive-complexity] 

function 'create_surfaces' has cognitive complexity of 12 (threshold 10)
{
for( const auto unused : geode::Range{ nb_surfaces } )
{
Expand All @@ -331,12 +331,12 @@
boundary_counter;
const auto nb_physical_tags =
geode::string_to_index( tokens.at( 7 ) );
for( const auto b : geode::Range{ geode::string_to_index(

Check warning on line 334 in src/geode/io/model/msh_input.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

src/geode/io/model/msh_input.cpp:334:33 [readability-identifier-length] 

variable name 'b' is too short, expected at least 3 characters
tokens.at( 8 + nb_physical_tags ) ) } )
{
const auto boundary_msh_id = geode::string_to_double(
tokens.at( 9 + nb_physical_tags + b ) );
auto it = boundary_counter.emplace(

Check warning on line 339 in src/geode/io/model/msh_input.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

src/geode/io/model/msh_input.cpp:339:26 [readability-identifier-length] 

variable name 'it' is too short, expected at least 3 characters
static_cast< geode::index_t >(
std::abs( boundary_msh_id ) ),
1 );
Expand Down Expand Up @@ -389,7 +389,7 @@
// TODO physical tags
const auto nb_physical_tags =
geode::string_to_index( tokens.at( 7 ) );
for( const auto b : geode::Range{ geode::string_to_index(

Check warning on line 392 in src/geode/io/model/msh_input.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

src/geode/io/model/msh_input.cpp:392:33 [readability-identifier-length] 

variable name 'b' is too short, expected at least 3 characters
tokens.at( 8 + nb_physical_tags ) ) } )
{
const auto boundary_msh_id = std::abs( geode::string_to_int(
Expand Down Expand Up @@ -425,7 +425,7 @@
{
geode_unused( unused );
std::getline( file_, line );
geode::index_t node_id;

Check warning on line 428 in src/geode/io/model/msh_input.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

src/geode/io/model/msh_input.cpp:428:32 [cppcoreguidelines-init-variables] 

variable 'node_id' is not initialized
geode::Point3D node;
std::tie( node_id, node ) = read_node( line );
nodes_[node_id - geode::internal::GMSH_OFFSET_START] = node;
Expand All @@ -438,9 +438,9 @@
const std::string& line )
{
const auto tokens = geode::string_split( line );
return std::make_tuple( geode::string_to_index( tokens.at( 0 ) ),
return { geode::string_to_index( tokens.at( 0 ) ),
read_node_coordinates(
tokens.at( 1 ), tokens.at( 2 ), tokens.at( 3 ) ) );
tokens.at( 1 ), tokens.at( 2 ), tokens.at( 3 ) ) };
}

void read_node_section_v4()
Expand Down Expand Up @@ -481,7 +481,7 @@
"[MSHInput::read_node_group] Parametric node coordinates "
"is not supported for now" );
absl::FixedArray< geode::index_t > node_ids( nb_nodes );
for( const auto n : geode::Range{ nb_nodes } )

Check warning on line 484 in src/geode/io/model/msh_input.cpp

View workflow job for this annotation

GitHub Actions / test / tidy

src/geode/io/model/msh_input.cpp:484:29 [readability-identifier-length] 

variable name 'n' is too short, expected at least 3 characters
{
std::getline( file_, line );
const auto node_tokens = geode::string_split( line );
Expand Down
Loading