Skip to content

CI: Use setup-msvc-dev action instead of hardcoding the VS install path on Windows #4861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seisman merged 2 commits into from
Aug 27, 2026
+8 −3
Merged

CI: Use setup-msvc-dev action instead of hardcoding the VS install path on Windows #4861

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f47d7f
CI: Use setup-msvc-dev action instead of hardcoding the VS install path
seisman Aug 25, 2026
a3d8077
Merge branch 'main' into ci/setup-msvc-dev
seisman Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions .github/workflows/ci_tests_dev.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,16 +105,21 @@ jobs:
path: 'gmt'
persist-credentials: false

# Build GMT from source on Linux/macOS, script is adapted from
# https://github.com/GenericMappingTools/gmt/blob/6.5.0/ci/build-gmt.sh
- name: Set up MSVC environment (Windows)
if: runner.os == 'Windows'
uses: TheMrMilchmann/setup-msvc-dev@368ef7d1ee4d1171b31d4a7f67f4d954f903f5a9 # v4.1.0
with:
arch: x64

@weiji14 weiji14 Aug 26, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an issue now, but we might need to set an or statement to the arch to x86_arm64 or amd64_arm64 when #3911 lands.


# Build GMT from source.
# Script is adapted from https://github.com/GenericMappingTools/gmt/blob/6.5.0/ci/build-gmt.sh
- name: Build GMT from source
shell: bash
run: |
cd gmt/
mkdir build
cd build
if [[ "$RUNNER_OS" == "Windows" ]]; then
cmd.exe /c "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat"
CMAKE_PREFIX_PATH="$MAMBA_ROOT_PREFIX/envs/pygmt/Library"
else
CMAKE_PREFIX_PATH="$MAMBA_ROOT_PREFIX/envs/pygmt"
Expand Down