Skip to content

Figure.sac: Plot seismograms in SAC format - #4854

Open
Chuan1937 wants to merge 8 commits into
mainfrom
figure-sac
Open

Figure.sac: Plot seismograms in SAC format#4854
Chuan1937 wants to merge 8 commits into
mainfrom
figure-sac

Conversation

@Chuan1937

@Chuan1937 Chuan1937 commented Aug 24, 2026

Copy link
Copy Markdown
Member

@Chuan1937 Chuan1937 changed the title add base parameters and tests for sac module Figure.sac: Plot seismograms in SAC format Aug 24, 2026
@Chuan1937 Chuan1937 self-assigned this Aug 24, 2026
@Chuan1937 Chuan1937 added the feature Brand new feature label Aug 24, 2026
@Chuan1937 Chuan1937 added this to the 0.20.0 milestone Aug 24, 2026
@Chuan1937
Chuan1937 requested a balanced review from Copilot August 24, 2026 05:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Comment thread pygmt/src/sac.py Outdated
Comment thread pygmt/src/sac.py Outdated
Comment thread pygmt/src/sac.py Outdated
Comment thread pygmt/src/sac.py Outdated
Chuan1937 and others added 5 commits August 24, 2026 13:31
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Comment thread pygmt/src/sac.py Outdated
Comment thread pygmt/src/sac.py
Comment on lines +115 to +122
fill
Paint the positive or negative portion of the traces. Use ``p``/``n`` to
paint the positive/negative portion [Default paints the positive
portion], ``+g`` *fill* to set the fill color [Default is ``"black"``],
``+z`` *zero* to define the zero line, and ``+t`` *t0*/*t1* to paint a
time window only. Can be repeated to paint the positive and negative
portions separately, e.g., ``["p+gblack", "n+gred"]``. Set to ``True``
to paint the positive portion with the default fill.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This parameter is not Pythonic yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Brand new feature

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants