Skip to content

Add filtering tags for gallery examples of projections#4643

Open
seisman wants to merge 6 commits into
mainfrom
doc/gallery-tag
Open

Add filtering tags for gallery examples of projections#4643
seisman wants to merge 6 commits into
mainfrom
doc/gallery-tag

Conversation

@seisman
Copy link
Copy Markdown
Member

@seisman seisman commented May 19, 2026

Changes in this PR:

  • Bump to sphinx-gallery >= 0.21.0
  • Add tags for projection gallery examples [Based on the figure and table in https://docs.generic-mapping-tools.org/dev/reference/options.html#coordinate-transformations-and-map-projections-the-j-option]

Preview: https://pygmt-dev--4643.org.readthedocs.build/en/4643/projections/index.html

The first PR to address #4599

@seisman seisman force-pushed the doc/gallery-tag branch from 497e5f5 to d140119 Compare May 19, 2026 09:24
@seisman seisman changed the title WIP + POC: Add dynamic filtering by tags for gallery examples Add filtering tags for gallery examples of projection May 19, 2026
@seisman seisman added the enhancement Improving an existing feature label May 19, 2026
@seisman seisman added this to the 0.19.0 milestone May 19, 2026
@seisman seisman marked this pull request as ready for review May 19, 2026 09:26
@seisman seisman requested a review from a team May 19, 2026 09:26
@seisman seisman changed the title Add filtering tags for gallery examples of projection Add filtering tags for gallery examples of projections May 19, 2026
@yvonnefroehlich
Copy link
Copy Markdown
Member

Looking at the example by Sphinx at https://sphinx-gallery.github.io/stable/auto_examples/index.html?#general-examples, there should be a nice tag symbol. However, in the preview of this PR, it looks a bit strange. Besides this, I feel it could improve the structure if "Tags" were written in bold font, but I think we cannot change this.

Preview of this PR Example by Sphinx
tag_symbol_pygmt tag_symbol_example

@seisman
Copy link
Copy Markdown
Member Author

seisman commented May 20, 2026

there should be a nice tag symbol. However, in the preview of this PR, it looks a bit strange.

I can see the tag symbol in the preview, so it's likely a browser issue.

I feel it could improve the structure if "Tags" were written in bold font, but I think we cannot change this.

Actually we can, I've adjusted the style in commit fe40f73

image

@seisman seisman added the needs review This PR has higher priority and needs review. label May 20, 2026
@yvonnefroehlich
Copy link
Copy Markdown
Member

there should be a nice tag symbol. However, in the preview of this PR, it looks a bit strange.

I can see the tag symbol in the preview, so it's likely a browser issue.

Your are probably right, on my smarphone it looks good.

I feel it could improve the structure if "Tags" were written in bold font, but I think we cannot change this.

Actually we can, I've adjusted the style in commit fe40f73

That's good and with the changes it looks much better.

Copy link
Copy Markdown
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think only Mollweide (equal-area) is missing a tag. Otherwise should be ok.

@seisman
Copy link
Copy Markdown
Member Author

seisman commented May 21, 2026

I think only Mollweide (equal-area) is missing a tag. Otherwise should be ok.

Nice catch. Fixed in f71ee74.

@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improving an existing feature final review call This PR requires final review and approval from a second reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants