Open
Conversation
Co-authored-by: seisman <3974108+seisman@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job for Windows
Fix Windows CI failure: remove NSIS from CPack generators
Aug 26, 2026
Co-authored-by: seisman <3974108+seisman@users.noreply.github.com>
joa-quim
reviewed
Aug 26, 2026
joa-quim
left a comment
joa-quim
left a comment
Member
There was a problem hiding this comment.
Removing NSIS why? That is what I use to create the installer. It would be good to have if working at the end.
seisman
changed the title
Member
It now installs NSIS by choco. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New GitHub Actions runner images don't have NSIS installed by default, so we need to install it.