Skip to content

Apply Configured MySQL Connection Pool Settings #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
x64-dev merged 1 commit into from
Aug 15, 2026
+16 −6
Merged

Apply Configured MySQL Connection Pool Settings #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions GenOnlineService/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,10 +400,12 @@ private static async Task InitializeDatabase(WebApplicationBuilder builder)
string? password = dbSettings.GetValue<string>("db_password");
UInt16? port = dbSettings.GetValue<UInt16>("db_port");

int? db_min_poolsize = dbSettings.GetValue<int>("db_min_poolsize");
int? db_max_poolsize = dbSettings.GetValue<int>("db_max_poolsize");
bool? db_use_pooling = dbSettings.GetValue<bool>("db_use_pooling");
bool? db_conn_reset = dbSettings.GetValue<bool>("db_conn_reset");
// Fall back to MySql.Data's own defaults when a key is absent, rather than silently
// disabling pooling / zeroing the pool size for deployments predating these settings.
int db_min_poolsize = dbSettings.GetValue<int?>("db_min_poolsize") ?? 0;
int db_max_poolsize = dbSettings.GetValue<int?>("db_max_poolsize") ?? 100;
bool db_use_pooling = dbSettings.GetValue<bool?>("db_use_pooling") ?? true;
bool db_conn_reset = dbSettings.GetValue<bool?>("db_conn_reset") ?? true;
int? db_connect_timeout = dbSettings.GetValue<int>("db_connect_timeout");
int? db_command_timeout = dbSettings.GetValue<int>("db_command_timeout");

Expand Down Expand Up @@ -451,7 +453,11 @@ private static async Task InitializeDatabase(WebApplicationBuilder builder)
Password = password,
ConnectionTimeout = (uint)db_connect_timeout,
DefaultCommandTimeout = (uint)db_command_timeout,
SslMode = MySql.Data.MySqlClient.MySqlSslMode.Preferred
SslMode = MySql.Data.MySqlClient.MySqlSslMode.Preferred,
Pooling = db_use_pooling,
MinimumPoolSize = (uint)db_min_poolsize,
MaximumPoolSize = (uint)db_max_poolsize,
ConnectionReset = db_conn_reset
};

// TODO_EFCORE: Consider use of ExecuteDeleteAsync and options.UseQueryTrackingBehavior(QueryTrackingBehavior.NoTracking);
Expand Down
6 changes: 5 additions & 1 deletion GenOnlineService/appsettings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,11 @@
"db_password": "dbpassword",
"db_port": 3306,
"db_connect_timeout": 10,
"db_command_timeout": 10
"db_command_timeout": 10,
"db_min_poolsize": 10,
"db_max_poolsize": 500,
"db_use_pooling": true,
"db_conn_reset": true
},
"MatchData": {
"upload_match_data": false,
Expand Down
Loading