fix: Prevent double-removal in CameraShakeSystemClass destructor - #565
Open
seer-by-sentry[bot] wants to merge 1 commit into
Open
fix: Prevent double-removal in CameraShakeSystemClass destructor#565seer-by-sentry[bot] wants to merge 1 commit into
seer-by-sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue CLIENT-45P by removing a redundant call to
CameraShakerList.Remove(obj)in theCameraShakeSystemClassdestructor. TheRemove_Head()method already detaches the object from the list, making the subsequentRemove(obj)call a double-removal. This double-removal corrupts the internal list pointers, leading to anEXCEPTION_ACCESS_VIOLATION_READcrash inGenericMultiListClass::Internal_Remove_List_Headduring process teardown.Fixes CLIENT-45P
This PR was automatically generated by Sentry. You can adjust this setting at any time.