Skip to content

AppCef: Check for non secure path#204

Closed
illusionyy wants to merge 1 commit into
GameTechDev:mainfrom
illusionyy:patch-3
Closed

AppCef: Check for non secure path#204
illusionyy wants to merge 1 commit into
GameTechDev:mainfrom
illusionyy:patch-3

Conversation

@illusionyy
Copy link
Copy Markdown

@illusionyy illusionyy commented Mar 4, 2024

Checks for non secure path, if not in "Program Files", raise an error since it will hit __debugbreak(); in libcef.dll. https://github.com/chromium/chromium/blob/d0988dbf7d0baed14bfe603aa8ab47ee77aa2372/content/browser/gpu/gpu_data_manager_impl_private.cc#L1788

 	libcef.dll!logging::LogMessage::HandleFatal(unsigned __int64 stack_start, const std::__Cr::basic_string<char,std::__Cr::char_traits<char>,std::__Cr::allocator<char>> & str_newline) Line 1036	C++
 	[Inline Frame] libcef.dll!logging::LogMessage::Flush::<lambda_0>::operator()() Line 740	C++
 	[Inline Frame] libcef.dll!absl::cleanup_internal::Storage<`lambda at ..\..\base\logging.cc:738:40'>::InvokeCallback() Line 87	C++
 	[Inline Frame] libcef.dll!absl::Cleanup<absl::cleanup_internal::Tag,`lambda at ..\..\base\logging.cc:738:40'>::~Cleanup() Line 106	C++
 	libcef.dll!logging::LogMessage::Flush() Line 923	C++
 	libcef.dll!logging::LogMessageFatal::~LogMessageFatal() Line 1041	C++
==>	libcef.dll!content::`anonymous namespace'::IntentionallyCrashBrowserForUnusableGpuProcess() Line 448	C++
 	libcef.dll!content::GpuDataManagerImplPrivate::FallBackToNextGpuMode() Line 1764	C++
 	libcef.dll!content::GpuDataManagerImpl::FallBackToNextGpuMode() Line 374	C++
 	libcef.dll!content::GpuProcessHost::RecordProcessCrash() Line 1382	C++
 	libcef.dll!content::GpuProcessHost::OnProcessLaunchFailed(int error_code) Line 984	C++
 	libcef.dll!content::BrowserChildProcessHostImpl::OnProcessLaunchFailed(int error_code) Line 609	C++
 	libcef.dll!content::ChildProcessLauncher::Notify(content::internal::ChildProcessLauncherHelper::Process process, unsigned long last_error, int error_code) Line 183	C++
 	libcef.dll!content::internal::ChildProcessLauncherHelper::PostLaunchOnClientThread(content::internal::ChildProcessLauncherHelper::Process process, unsigned long last_error, int error_code) Line 254	C++
 	

@illusionyy illusionyy force-pushed the patch-3 branch 2 times, most recently from abece37 to 2409a81 Compare March 5, 2024 20:28
@planetchili
Copy link
Copy Markdown
Collaborator

Changes to process organization has made this unnecessary. Furthermore, there are registry settings that allow running uiAccess=true modules from any location that can sometimes be helpful if used (carefully) during development, so adding this restriction would have caused some small friction in dev flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants