[GFX-551] fix(server): 移除 PipelineFilter 默认构造函数限制以支持 DI 构造 - #18
Merged
Conversation
对齐上游 kerryjiang/SuperSocket@e4531951,将 MultipleServerHostBuilder.AddServer 与 HostBuilderExtensions.AsSuperSocketHostBuilder 的 TPipelineFilter 约束由 'class, IPipelineFilter<>, new()' 改为 'class, IPipelineFilter<>',使带依赖注入构造函数的 PipelineFilter 可经这些入口正常注册。 Linear: GFX-551
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough本次变更移除三个主机生成器 API 对 Changes管道筛选器约束
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
上游基准:kerryjiang/SuperSocket @ f7cf1f5,对齐上游 e453195(refactor pipeline filter constraints to class type)与 1f4d90b(TPipelineFilter doesn't have to be new())。
改动
将 3 个公共入口的 TPipelineFilter 约束由 'class, IPipelineFilter, new()' 改为 'class, IPipelineFilter',使带依赖注入构造函数的 PipelineFilter 可经这些入口正常注册:
未动 DefaultConstructorPipelineFilterFactory(其 new() 是类型设计必需,上游也未改动)。
验证
dotnet build GameFrameX.SuperSocket.sln -c Release:0 Error,227 Warning(全为预存 CS1591/CS0114,与本次改动无关)。
Linear: GFX-551
Summary by CodeRabbit