Skip to content

test: update tests with latest commits from main#220

Merged
beckermr merged 27 commits intomainfrom
update-tests-galsim-2026-04-18
Apr 18, 2026
Merged

test: update tests with latest commits from main#220
beckermr merged 27 commits intomainfrom
update-tests-galsim-2026-04-18

Conversation

@beckermr
Copy link
Copy Markdown
Collaborator

@beckermr beckermr commented Apr 16, 2026

This PR added some changes:

  • Some of the numeric operations now round to int types like galsim does.
  • More of the code uses the jax .at syntax to enable in-place operations when things are inside JIT.
  • Arrays read from numpy are converted to native byteorder before they are used in JAX. This seems to be needed with jax version 0.10 and later.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 16, 2026

Merging this PR will degrade performance by 39.3%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 2 regressed benchmarks
✅ 34 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation test_benchmark_interpimage_flux_frac[run] 1.7 ms 2.7 ms -34.79%
WallTime test_benchmark_moffat_init[run] 56.8 µs 93.7 µs -39.3%

Comparing update-tests-galsim-2026-04-18 (11e59bb) with main (d9f0155)

Open in CodSpeed

Comment thread .github/workflows/python_package.yaml Outdated
@beckermr beckermr merged commit 88d4aec into main Apr 18, 2026
9 checks passed
@beckermr beckermr deleted the update-tests-galsim-2026-04-18 branch April 18, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant