Fix filters with intermediate null tag values - #44
Open
tyrasd wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQL has some "unexpected" behaviour when it comes to handling NULL values, for example the
= ANYarray comparison results in null if the value it operates on is NULL (instead offalse).And when this is combined with the boolean
NOToperator, this results in cases where one would expect a true-thy value, but getsNULLinstead.For example, a filter like
amenity=bench and NOT (foo in (bar))will not return features withamenity=benchand nofootag.This PR hardens the filter statements which can have intermediate
NULLvalues to include extrais not nullchecks such that the filters can also be used together with aNOTnegation.TODO:
assert [<Record count=3936621437>] == [<Record count=765879661>]– not sure what's going on there...