fix: apple-clang build on macos - #4138
Merged
Merged
Conversation
victorapm
requested review from
MelReyCG,
OmarDuran,
bd713,
corbett5,
joshua-white,
rrsettgast and
wrtobin
as code owners
September 4, 2026 18:53
victorapm
added
flag: ready for review
flag: requires updated TPL(s)
OmarDuran
approved these changes
Sep 9, 2026
OmarDuran
left a comment
OmarDuran
left a comment
Contributor
There was a problem hiding this comment.
Thank you @victorapm, for fixing this. I don't have any comments on this one.
bd713
approved these changes
Sep 9, 2026
Contributor
Author
|
Needs an LC install after GEOS-DEV/thirdPartyLibs#364 and we're ready to merge @rrsettgast |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix build issues on MacOS
Unit test fixes:
Depends on GEOS-DEV/thirdPartyLibs#364
Closes #4053