Skip to content

Fix AOCC shadow warning and VTK global ID SIGFPE#4098

Open
sushma-4 wants to merge 2 commits into
developfrom
SY_patch_aocc
Open

Fix AOCC shadow warning and VTK global ID SIGFPE#4098
sushma-4 wants to merge 2 commits into
developfrom
SY_patch_aocc

Conversation

@sushma-4

Copy link
Copy Markdown

Pushed some changes that were needed to succesfully compile and pass unit tests in our environment (AOCC Compiler, AOCL).

  1. src/coreComponents/physicsSolvers/solidMechanics/contact/SolidMechanicsAugmentedLagrangianContact.cpp - No functional behavior changes, only the capture variable name is updated to avoid shadowing the class member m_symmetric. AOCC treats the warning as an error due to -Werror=shadow
  2. src/coreComponents/mesh/generators/VTKUtilities.cpp - testSinglePhaseMFDPolyhedral failed intermittently during mesh initialization. The failures occurred before solver setup and consistently originated from VTK while generating GlobalIds. Hence, Wrapping the call to vtkGenerateGlobalIds::Update() with LvArray::system::FloatingPointExceptionGuard to temporarily disable FPE trapping

@sushma-4 sushma-4 added the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label Jul 22, 2026
@sushma-4 sushma-4 self-assigned this Jul 22, 2026
@sushma-4 sushma-4 added the ci: run integrated tests Allows to run the integrated tests in GEOS CI label Jul 22, 2026
@jhuang2601 jhuang2601 added the flag: no rebaseline Does not require rebaseline label Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants