Fix AOCC shadow warning and VTK global ID SIGFPE#4098
Open
sushma-4 wants to merge 2 commits into
Open
Conversation
sushma-4
requested review from
OmarDuran,
bd713,
castelletto1,
jafranc,
jhuang2601,
rrsettgast and
wrtobin
as code owners
July 21, 2026 17:08
jafranc
approved these changes
Jul 22, 2026
jhuang2601
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pushed some changes that were needed to succesfully compile and pass unit tests in our environment (AOCC Compiler, AOCL).
src/coreComponents/physicsSolvers/solidMechanics/contact/SolidMechanicsAugmentedLagrangianContact.cpp- No functional behavior changes, only the capture variable name is updated to avoid shadowing the class memberm_symmetric. AOCC treats the warning as an error due to-Werror=shadowsrc/coreComponents/mesh/generators/VTKUtilities.cpp-testSinglePhaseMFDPolyhedralfailed intermittently during mesh initialization. The failures occurred before solver setup and consistently originated from VTK while generating GlobalIds. Hence, Wrapping the call tovtkGenerateGlobalIds::Update()withLvArray::system::FloatingPointExceptionGuardto temporarily disable FPE trapping