refactor: Phase-field and damage solid model cleanup, refactor#4096
Open
frankfeifan wants to merge 9 commits into
Open
refactor: Phase-field and damage solid model cleanup, refactor#4096frankfeifan wants to merge 9 commits into
frankfeifan wants to merge 9 commits into
Conversation
frankfeifan
requested review from
OmarDuran,
bd713,
castelletto1,
dkachuma,
herve-gross,
jhuang2601 and
rrsettgast
as code owners
July 16, 2026 20:54
frankfeifan
added
ci: run CUDA builds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To remove dead codes, unify duplicated logic, rename unclear variables, and decouple crack model type from decomposition scheme to enable more options of the phase-field model.
LocalDissipationOptioninto a constitutive-level definitionFractureModelType(Brittle/Cohesive/Nucleation), and decouple it from decomposition scheme to allow for more phase-field model combinations, e.g.,- Brittle + Linear (AT1)/Quadratic (AT2) + No decomposition/Spectral/VolDev
- Cohesive + Linear + No decomposition/Spectral/VolDev
- Nucleation + Linear + No decomposition
Still wip, and more to come ...