Conversation
Contributor
|
That looks great, Bertrand. Even though |
bd713
marked this pull request as ready for review
April 27, 2026 17:09
bd713
requested review from
OmarDuran,
jafranc,
rrsettgast and
wrtobin
as code owners
April 27, 2026 17:09
added 2 commits
May 20, 2026 16:18
bd713
requested review from
frankfeifan,
herve-gross and
jhuang2601
as code owners
July 28, 2026 01:27
bd713
force-pushed
the
feat/bd713/meshScatter
branch
from
July 28, 2026 02:03
5b8df17 to
ffed9d2
Compare
joshua-white
approved these changes
Jul 28, 2026
joshua-white
left a comment
Contributor
There was a problem hiding this comment.
Nice. Only suggestion might be to add a log note if a "large" mesh and kdtree are detected, suggesting user consider something else.
# Conflicts: # src/coreComponents/integrationTests/meshTests/testVTKImport.cpp # src/coreComponents/mesh/generators/VTKUtilities.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current strategy to scatter the mesh initially loaded by rank 0 uses
vtkRedistributeDataSetFilter(kd-tree partitioning). This approach can take several minutes for large meshes (10s of millions of elements) when redistributed among 1000+ ranks.Recent example: A 136M cell mesh redistributed to 1024 ranks takes about 17 minutes with the current kd-tree approach.
Solution
This PR adds partitioning strategies that bypass the VTK library's bottleneck, available via the new
scatterMethodXML attribute.Available strategies
kdtreecontiguouscartesian-x/-y/-zpartition countsrcbRemark
The resulting partitions can be further refined and improved via calls to
ParMetisorPTScotchwithpartitionRefinement>0Benchmark
Rebaseline needed
57/67 failures are XML metadata diff:
Group has a child 'scatterMethod' in the file to compare but not the baseline file.10/67 are real partitioning changes in contact cases as we switched from Morton's algorithm to RCB