Open
Conversation
tjb-ltk
added
the
ci: run integrated tests
tjb-ltk
added
flag: no rebaseline
tjb-ltk
changed the title
…on, probably an artifact of this unit test
dkachuma
reviewed
Apr 15, 2026
| { | ||
| real64 dMult[CP_Deriv::nDer]{}; | ||
| real64 totalEnthalpy=0; | ||
| dMult[CP_Deriv::dP] = 0; |
Contributor
There was a problem hiding this comment.
Suggested change
| dMult[CP_Deriv::dP] = 0; |
dMult[CP_Deriv::nDer]{}; should normally initialise to zero. Otherwise we have to initialise everything including dT and dC.
| m_wellElemPhaseEnthalpy[iwelem][0][iphase] * m_wellElemPhaseVolFrac[iwelem][iphase] * m_dWellElemPhaseDensity[iwelem][0][iphase][Deriv::dT]; | ||
| real64 dProp_dC[numComp]{}; | ||
| applyChainRule( NC, | ||
| m_dWellElemCompFrac_dCompDens[iwelem], |
Contributor
There was a problem hiding this comment.
Instead of having these chain rules within the loop. Can't we calculate the dC derivative and then do the chain rule after summing over the loop. It would remove a few flops in the loop and the dProp allocations.
Contributor
Author
There was a problem hiding this comment.
good point, I'll make that change
| discretization="fluidTPFA" | ||
| temperature="368.15" | ||
| useMass="1" | ||
| useMass="0" |
Contributor
There was a problem hiding this comment.
I'm guessing the removal of thermal here is for debugging?
…l inj well calcs need a bit of streamlining, but first lets see if the reg tests still work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix to thermal well inflow derivatives.