feat: Strain Dependent Permeability model - #3824
Open
jhuang2601 wants to merge 24 commits into
Open
jhuang2601 wants to merge 24 commits into
jhuang2601 wants to merge 24 commits into
Conversation
3 tasks
rrsettgast
approved these changes
Sep 26, 2025
jhuang2601
marked this pull request as ready for review
May 15, 2026 22:02
jhuang2601
requested review from
castelletto1,
dkachuma and
frankfeifan
as code owners
May 15, 2026 22:02
dkachuma
approved these changes
Jun 1, 2026
| { | ||
| real64 const porosityRatio = currentPorosity / referencePorosity; | ||
|
|
||
| for( localIndex i = 0; i < permeability.size(); ++i ) |
Contributor
There was a problem hiding this comment.
Suggested change
| for( localIndex i = 0; i < permeability.size(); ++i ) | |
| for( localIndex i = 0; i < 3; ++i ) |
I would hard-code this
| referencePermeability[2] = m_referencePermeability[k][0][2]; | ||
|
|
||
| compute( referencePorosity, | ||
| referencePermeability, |
Contributor
There was a problem hiding this comment.
Suggested change
| referencePermeability, | |
| m_referencePermeability[k][0], |
No need to copy
jhuang2601
requested review from
OmarDuran,
jafranc and
joshua-white
as code owners
September 11, 2026 13:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a volumetric Strain Dependent Permeability model for porous rock (Chin et al., 2000)