fix(flowchat): fix arbitrary turn navigation across renderer handoff - #1935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix arbitrary FlowChat turn navigation during and after streaming, including navigation across the static-history to Virtuoso renderer handoff.
Type and Areas
Type:
Areas:
Motivation / Impact
Previously, arbitrary turn navigation could remain pending, jump back to the bottom, or stop working after a new turn switched rendering modes.
This change:
rangeChangedand bounded retries.ScrollAnchorto the concrete scroller element.Verification
pnpm run type-check:webpnpm --dir src/web-ui run lintpnpm --dir src/web-ui run test:run src/flow_chat/components/modern/VirtualMessageList.session-boundary.test.tsx src/flow_chat/components/modern/ScrollAnchor.test.tsxgit diff --checkReviewer Notes
firstItemIndexremains only a rendering coordinate.rangeChangedparticipates in target materialization, with bounded RAF retries as fallback.flowchat-turn-navigation-fix-plan.mdfile is an explicitly requested durable diagnostic and design artifact.Checklist