Fix FlowChat tail-follow transitions and delayed shrink jumps - #1908
Merged
Conversation
- Revert the streamed line-growth smoothing introduced in fa6a727. - Fix the transition from new-turn pinning to tail-follow mode. - Prevent severe viewport flickering during streamed output.
- Coordinate pinned-turn handoff with natural viewport-tail geometry. - Replace competing follow scroll writes with a single smooth RAF loop. - Recover delayed virtualizer shrink clamps through viewport transactions. - Preserve collapse anchors across late measurements with generation-based quiet settlement. - Add regression coverage and document FlowChat scroll stability rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves FlowChat viewport stability across pinned-turn handoff, smooth tail follow, animated card collapse, and delayed virtualizer measurements.
Fixes #
Type and Areas
Type:
Regression fix, performance/stability, test, docs
Areas:
Web UI / FlowChat
Motivation / Impact
FlowChat could fail to transition from a pinned user message into tail follow, visibly jump during smooth follow, or drop when Virtuoso committed a delayed item shrink after collapse protection had been released.
This change:
Verification
pnpm run type-check:webpnpm run lint:webpnpm --dir src/web-ui run test:run src/flow_chat/components/modern/FlowChatViewportCoordinator.test.ts src/flow_chat/components/modern/useFlowChatFollowOutput.test.tsx src/flow_chat/components/modern/VirtualMessageList.session-boundary.test.tsxgit diff --cached --checkReviewer Notes
Checklist